From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ts1Jo-0000Jn-Kc for qemu-devel@nongnu.org; Sun, 06 Jan 2013 20:16:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ts1Jm-00014F-T0 for qemu-devel@nongnu.org; Sun, 06 Jan 2013 20:16:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ts1Jm-000147-LB for qemu-devel@nongnu.org; Sun, 06 Jan 2013 20:15:58 -0500 Date: Mon, 7 Jan 2013 09:15:58 +0800 From: Amos Kong Message-ID: <20130107011558.GA20634@t430s.redhat.com> References: <1354799230-30904-1-git-send-email-pbonzini@redhat.com> <1354799230-30904-29-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1354799230-30904-29-git-send-email-pbonzini@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 28/32] softmmu: move include files to include/sysemu/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, afaerber@suse.de On Thu, Dec 06, 2012 at 02:07:06PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > arch_init.c | 6 +++--- > audio/audio.c | 2 +- > audio/winwaveaudio.c | 2 +- > balloon.c | 4 ++-- > block-migration.c | 2 +- ... > hw/z2.c | 4 ++-- > hw/zynq_slcr.c | 2 +- > include/exec/exec-memory.h | 2 +- > include/exec/softmmu_template.h | 2 +- > arch_init.h =3D> include/sysemu/arch_init.h | 0 Failed to compile latest qemu(8e4a424b305e29dc0e454f52df3b35577f342975) o= n Fedora17 $ rpm -q gcc gcc-4.7.2-2.fc17.x86_64 It's fine in RHEL. # rpm -q gcc gcc-4.4.6-4.el6.x86_64 Include issue of gcc ? # ./configure --target-list=3Dx86_64-softmmu --enable-debug # make ... CC x86_64-softmmu/arch_init.o In file included from /home/devel/qemu/include/sysemu/arch_init.h:4:0, from /home/devel/qemu/arch_init.c:36: ./qmp-commands.h:3:1: error: expected identifier or =E2=80=98(=E2=80=99 b= efore =E2=80=98{=E2=80=99 token ./qmp-commands.h:10:2: error: expected identifier or =E2=80=98(=E2=80=99 = before =E2=80=98,=E2=80=99 token ./qmp-commands.h:20:2: error: expected identifier or =E2=80=98(=E2=80=99 = before =E2=80=98,=E2=80=99 token ./qmp-commands.h:30:2: error: expected identifier or =E2=80=98(=E2=80=99 = before =E2=80=98,=E2=80=99 token ./qmp-commands.h:40:2: error: expected identifier or =E2=80=98(=E2=80=99 = before =E2=80=98,=E2=80=99 token ./qmp-commands.h:50:2: error: expected identifier or =E2=80=98(=E2=80=99 = before =E2=80=98,=E2=80=99 token ./qmp-commands.h:60:2: error: expected identifier or =E2=80=98(=E2=80=99 = before =E2=80=98,=E2=80=99 token ./qmp-commands.h:70:2: error: expected identifier or =E2=80=98(=E2=80=99 = before =E2=80=98,=E2=80=99 token ./qmp-commands.h:80:2: error: expected identifier or =E2=80=98(=E2=80=99 = before =E2=80=98,=E2=80=99 token ./qmp-commands.h:90:2: error: expected identifier or =E2=80=98(=E2=80=99 = before =E2=80=98,=E2=80=99 token ./qmp-commands.h:100:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:110:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:120:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:130:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:140:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:154:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:164:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:174:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:184:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:194:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:204:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:214:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:224:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:233:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:244:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:254:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:264:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:274:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:284:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:294:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:304:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:314:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:323:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token ./qmp-commands.h:333:2: error: expected identifier or =E2=80=98(=E2=80=99= before =E2=80=98,=E2=80=99 token /home/devel/qemu/arch_init.c:104:28: error: =E2=80=98QEMU_ARCH_I386=E2=80= =99 undeclared here (not in a function) make[1]: *** [arch_init.o] Error 1 make: *** [subdir-x86_64-softmmu] Error 2 Amos