From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TsDWJ-0005hm-0C
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 09:17:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TsDWD-0000rV-Ti
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 09:17:42 -0500
Received: from mail-bk0-f48.google.com ([209.85.214.48]:56316)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TsDWD-0000rP-MA
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 09:17:37 -0500
Received: by mail-bk0-f48.google.com with SMTP id jc3so8403375bkc.21
	for <qemu-devel@nongnu.org>; Mon, 07 Jan 2013 06:17:36 -0800 (PST)
Date: Mon, 7 Jan 2013 15:17:34 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130107141734.GC18749@stefanha-thinkpad.redhat.com>
References: <1354878909-21369-1-git-send-email-dmitry@daynix.com>
	<1354878909-21369-4-git-send-email-dmitry@daynix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1354878909-21369-4-git-send-email-dmitry@daynix.com>
Subject: Re: [Qemu-devel] [PATCH V8 3/5] Adding common definitions for
 VMWARE devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>, Gerhard Wiesinger <lists@wiesinger.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>

On Fri, Dec 07, 2012 at 01:15:07PM +0200, Dmitry Fleytman wrote:
> diff --git a/hw/vmxnet_debug.h b/hw/vmxnet_debug.h
> new file mode 100644
> index 0000000..faa1431
> --- /dev/null
> +++ b/hw/vmxnet_debug.h
> @@ -0,0 +1,121 @@
> +/*
> + * QEMU VMWARE VMXNET* paravirtual NICs - debugging facilities
> + *
> + * Copyright (c) 2012 Ravello Systems LTD (http://ravellosystems.com)
> + *
> + * Developed by Daynix Computing LTD (http://www.daynix.com)
> + *
> + * Authors:
> + * Dmitry Fleytman <dmitry@daynix.com>
> + * Tamir Shomer <tamirs@daynix.com>
> + * Yan Vugenfirer <yan@daynix.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + *
> + */
> +
> +#ifndef _QEMU_VMXNET_DEBUG_H
> +#define _QEMU_VMXNET_DEBUG_H
> +
> +#ifdef VMXNET_VERSION_2
> +    #define VMXNET_DEVICE_NAME "vmxnet"
> +#elif defined VMXNET_VERSION_3
> +    #define VMXNET_DEVICE_NAME "vmxnet3"
> +#else
> +    #error "VMXNET version is not defined"
> +#endif

Please drop the VMXNET_VERSION_* conditional dead code, only version 3
is used.