From: Stefan Hajnoczi <stefanha@gmail.com>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>,
Gerhard Wiesinger <lists@wiesinger.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V8 5/5] Adding VMXNET3 device implementation
Date: Mon, 7 Jan 2013 15:52:07 +0100 [thread overview]
Message-ID: <20130107145207.GE18749@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1354878909-21369-6-git-send-email-dmitry@daynix.com>
On Fri, Dec 07, 2012 at 01:15:09PM +0200, Dmitry Fleytman wrote:
> +static void vmxnet3_get_ring_from_file(QEMUFile *f, Vmxnet3Ring *r)
> +{
> +#if HWADDR_BITS == 64
> + r->pa = qemu_get_be64(f);
> +#else
> + r->pa = qemu_get_be32(f);
> +#endif
hw/virtio.c always uses be64 for its hwaddr pa field. That way you
avoid the #ifdefs.
> +#if HWADDR_BITS == 64
> + VMSTATE_UINT64(drv_shmem, VMXNET3State),
> + VMSTATE_UINT64(temp_shared_guest_driver_memory, VMXNET3State),
> +#else
> + VMSTATE_UINT32(drv_shmem, VMXNET3State),
> + VMSTATE_UINT32(temp_shared_guest_driver_memory, VMXNET3State),
> +#endif
The hardware register interface is 2 32-bit registers. Can you use
uint64_t for these fields and avoid the #ifdefs?
next prev parent reply other threads:[~2013-01-07 14:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 11:15 [Qemu-devel] [PATCH V8 0/5] VMXNET3 paravirtual NIC device implementation Dmitry Fleytman
2012-12-07 11:15 ` [Qemu-devel] [PATCH V8 1/5] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes Dmitry Fleytman
2012-12-07 11:15 ` [Qemu-devel] [PATCH V8 2/5] Adding utility function net_checksum_add_iov() for iovec checksum calculation Dmitry Fleytman
2013-01-07 14:04 ` Stefan Hajnoczi
2013-01-11 13:33 ` Dmitry Fleytman
2012-12-07 11:15 ` [Qemu-devel] [PATCH V8 3/5] Adding common definitions for VMWARE devices Dmitry Fleytman
2013-01-07 14:17 ` Stefan Hajnoczi
2013-01-11 13:35 ` Dmitry Fleytman
2013-01-11 15:42 ` Stefan Hajnoczi
2013-01-12 16:14 ` Dmitry Fleytman
2012-12-07 11:15 ` [Qemu-devel] [PATCH V8 4/5] Adding packet abstraction for VMWARE network devices Dmitry Fleytman
2013-01-07 14:35 ` Stefan Hajnoczi
2013-01-12 16:16 ` Dmitry Fleytman
2012-12-07 11:15 ` [Qemu-devel] [PATCH V8 5/5] Adding VMXNET3 device implementation Dmitry Fleytman
2013-01-07 14:52 ` Stefan Hajnoczi [this message]
2013-01-12 16:17 ` Dmitry Fleytman
2013-03-27 14:43 ` Alexander Graf
2012-12-26 9:26 ` [Qemu-devel] [PATCH V8 0/5] VMXNET3 paravirtual NIC " Dmitry Fleytman
2013-01-07 15:01 ` Stefan Hajnoczi
2013-01-09 16:16 ` Dmitry Fleytman
2013-01-07 14:14 ` Stefan Hajnoczi
2013-01-12 16:20 ` Dmitry Fleytman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107145207.GE18749@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=anthony@codemonkey.ws \
--cc=dmitry@daynix.com \
--cc=lists@wiesinger.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).