From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TsE3i-00045b-SY
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 09:52:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TsE3f-00017a-Kt
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 09:52:14 -0500
Received: from mail-bk0-f51.google.com ([209.85.214.51]:53868)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TsE3f-00016d-EQ
	for qemu-devel@nongnu.org; Mon, 07 Jan 2013 09:52:11 -0500
Received: by mail-bk0-f51.google.com with SMTP id ik5so8571108bkc.38
	for <qemu-devel@nongnu.org>; Mon, 07 Jan 2013 06:52:10 -0800 (PST)
Date: Mon, 7 Jan 2013 15:52:07 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130107145207.GE18749@stefanha-thinkpad.redhat.com>
References: <1354878909-21369-1-git-send-email-dmitry@daynix.com>
	<1354878909-21369-6-git-send-email-dmitry@daynix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1354878909-21369-6-git-send-email-dmitry@daynix.com>
Subject: Re: [Qemu-devel] [PATCH V8 5/5] Adding VMXNET3 device implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Yan Vugenfirer <yan@daynix.com>, Gerhard Wiesinger <lists@wiesinger.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>

On Fri, Dec 07, 2012 at 01:15:09PM +0200, Dmitry Fleytman wrote:
> +static void vmxnet3_get_ring_from_file(QEMUFile *f, Vmxnet3Ring *r)
> +{
> +#if HWADDR_BITS == 64
> +    r->pa = qemu_get_be64(f);
> +#else
> +    r->pa = qemu_get_be32(f);
> +#endif

hw/virtio.c always uses be64 for its hwaddr pa field.  That way you
avoid the #ifdefs.

> +#if HWADDR_BITS == 64
> +            VMSTATE_UINT64(drv_shmem, VMXNET3State),
> +            VMSTATE_UINT64(temp_shared_guest_driver_memory, VMXNET3State),
> +#else
> +            VMSTATE_UINT32(drv_shmem, VMXNET3State),
> +            VMSTATE_UINT32(temp_shared_guest_driver_memory, VMXNET3State),
> +#endif

The hardware register interface is 2 32-bit registers.  Can you use
uint64_t for these fields and avoid the #ifdefs?