From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsGiV-0008QR-Id for qemu-devel@nongnu.org; Mon, 07 Jan 2013 12:42:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsGiS-0005kF-PH for qemu-devel@nongnu.org; Mon, 07 Jan 2013 12:42:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsGiS-0005k2-Hb for qemu-devel@nongnu.org; Mon, 07 Jan 2013 12:42:28 -0500 Date: Mon, 7 Jan 2013 19:46:16 +0200 From: "Michael S. Tsirkin" Message-ID: <20130107174616.GA8234@redhat.com> References: <1355761490-10073-1-git-send-email-pbonzini@redhat.com> <20121217214336.GA11991@redhat.com> <50D01AEE.2010508@redhat.com> <50D02AB6.9050208@redhat.com> <20121218094913.GC19090@redhat.com> <50D05634.1010401@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <50D05634.1010401@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Tue, Dec 18, 2012 at 12:40:36PM +0100, Paolo Bonzini wrote: > >> ... besides, this only works if the reset callback of > >> vdev->binding_opaque remembers to call virtio_reset (in the s390 > >> bindings, it doesn't and this series fixes it). > >=20 > > That's a separate bug I think. >=20 > Yes, I agree. >=20 > Paolo Anyway, I think the only argument is about a bit of code duplication, we can fix it up later. Andreas F=E4rber pointed out what looks like a buglet in this patchset, were you going to repost a fixed one?