From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJa6-0006HF-6V for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:46:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsJa1-00083s-5z for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:46:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJa0-00083f-TJ for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:45:57 -0500 Date: Mon, 7 Jan 2013 22:49:38 +0200 From: "Michael S. Tsirkin" Message-ID: <20130107204938.GB10575@redhat.com> References: <1354887155-32281-1-git-send-email-fred.konrad@greensocs.com> <20121217154508.GA28712@redhat.com> <20121218110153.GC22586@redhat.com> <50D053CC.9040203@greensocs.com> <20130107195843.GC8679@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, afaerber@suse.de, KONRAD =?iso-8859-1?Q?Fr=E9d=E9ric?= On Mon, Jan 07, 2013 at 08:02:32PM +0000, Peter Maydell wrote: > On 7 January 2013 19:58, Michael S. Tsirkin wrote: > > On Tue, Dec 18, 2012 at 12:30:20PM +0100, KONRAD Fr=E9d=E9ric wrote: > >> The modifications will be transparent to the user, as we will keep > >> virtio-x-pci devices. > > > > Then what's the point of all this? > > > > -device virtio-pci,id=3Dtransport1 -device virtio-net,bus=3Dtransport= 1 > > > > or > > > > -device virtio-mmio,id=3Dtransport1 -device virtio-net,bus=3Dtranspor= t1 > > > > Is simply an insane way to create a network device. >=20 > 1. You wouldn't create the virtio-mmio transport on the command line, > the machine model does it (it has to because it's a sysbus device > and it needs the address/irq lines wiring up properly), so it's just > "-device virtio-net" (and let qemu find the bus automatically) Bus auto-detection sounds good and would be nice for pci too. We had things like model=3Dvirtio originally which is pretty close. But the issue is, how then do you pass bus specific arguments like pci slot? This is what caused us to go the virtio-net-pci route to begin with. > 2. We shouldn't be making command line simplicity drive how we > model devices inside QEMU. Confused. I was told that enabling -device virtio-pci,id=3Dtransport1 -device virtio-net,bus=3Dtransport1 is the reason we have this patchset. > If we wanted to do that we should have > stuck with the old -net command line arguments which are rather > more userfriendly IMHO. The main thing that confused people with -net was the vlans and the need to specify -net twice. A good UI would have been e.g. -nic model=3Dvirtio,net=3Duser. But one bad UI does not justify another one. > If commandline confusion is getting to > be a problem with all the -device foo stuff then we should probably > fix that at the UI level. >=20 > -- PMM I'd like to see a proposal about how we are going to do this. --=20 MST