From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36201)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TsTKw-0007JU-Uv
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 02:11:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TsTKu-0006lb-AM
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 02:11:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:1639)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TsTKu-0006lW-1U
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 02:11:00 -0500
Date: Tue, 8 Jan 2013 09:14:39 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130108071439.GJ11305@redhat.com>
References: <1356690724-37891-1-git-send-email-jasowang@redhat.com>
	<1356690724-37891-8-git-send-email-jasowang@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1356690724-37891-8-git-send-email-jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 07/12] virtio: introduce virtio_queue_del()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: krkumar2@in.ibm.com, aliguori@us.ibm.com, kvm@vger.kernel.org, mprivozn@redhat.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org, stefanha@redhat.com, jwhan@filewood.snu.ac.kr, shiyer@redhat.com

On Fri, Dec 28, 2012 at 06:31:59PM +0800, Jason Wang wrote:
> Some device (such as virtio-net) needs the ability to destroy or re-order the
> virtqueues, this patch adds a helper to do this.
> 
> Signed-off-by: Jason Wang <jasowang>

Actually del_queue unlike what the subject says :)

> ---
>  hw/virtio.c |    9 +++++++++
>  hw/virtio.h |    2 ++
>  2 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/virtio.c b/hw/virtio.c
> index f40a8c5..bc3c9c3 100644
> --- a/hw/virtio.c
> +++ b/hw/virtio.c
> @@ -700,6 +700,15 @@ VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
>      return &vdev->vq[i];
>  }
>  
> +void virtio_del_queue(VirtIODevice *vdev, int n)
> +{
> +    if (n < 0 || n >= VIRTIO_PCI_QUEUE_MAX) {
> +        abort();
> +    }
> +
> +    vdev->vq[n].vring.num = 0;
> +}
> +
>  void virtio_irq(VirtQueue *vq)
>  {
>      trace_virtio_irq(vq);
> diff --git a/hw/virtio.h b/hw/virtio.h
> index 7c17f7b..f6cb0f9 100644
> --- a/hw/virtio.h
> +++ b/hw/virtio.h
> @@ -138,6 +138,8 @@ VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
>                              void (*handle_output)(VirtIODevice *,
>                                                    VirtQueue *));
>  
> +void virtio_del_queue(VirtIODevice *vdev, int n);
> +
>  void virtqueue_push(VirtQueue *vq, const VirtQueueElement *elem,
>                      unsigned int len);
>  void virtqueue_flush(VirtQueue *vq, unsigned int count);
> -- 
> 1.7.1