From: Stefan Hajnoczi <stefanha@gmail.com>
To: Nickolai Zeldovich <nickolai@csail.mit.edu>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions
Date: Tue, 8 Jan 2013 10:03:36 +0100 [thread overview]
Message-ID: <20130108090336.GA31977@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1357591119-40326-1-git-send-email-nickolai@csail.mit.edu>
On Mon, Jan 07, 2013 at 03:38:39PM -0500, Nickolai Zeldovich wrote:
> memcpy() for overlapping regions is undefined behavior; use memmove()
> instead in readline_hist_add().
>
> Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
> ---
> readline.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I made a slight modification: keep the tab characters since the
surrounding code still uses them.
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
next prev parent reply other threads:[~2013-01-08 9:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 20:38 [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions Nickolai Zeldovich
2013-01-07 21:36 ` Richard Henderson
2013-01-08 9:03 ` Stefan Hajnoczi [this message]
2013-01-09 20:43 ` Blue Swirl
2013-01-10 12:43 ` Stefan Hajnoczi
2013-01-12 10:46 ` Blue Swirl
2013-01-14 9:09 ` Stefan Hajnoczi
2013-01-17 20:13 ` Blue Swirl
2013-01-18 11:04 ` Stefan Hajnoczi
2013-01-19 9:04 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108090336.GA31977@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=nickolai@csail.mit.edu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).