qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Alexander Graf <agraf@suse.de>
Cc: Riku Voipio <riku.voipio@linaro.org>,
	Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix mips 32-on-64 prealloc case
Date: Tue, 8 Jan 2013 16:45:16 +0100	[thread overview]
Message-ID: <20130108154516.GA25390@ohm.aurel32.net> (raw)
In-Reply-To: <1357219038-841-1-git-send-email-agraf@suse.de>

On Thu, Jan 03, 2013 at 02:17:18PM +0100, Alexander Graf wrote:
> MIPS only supports 31 bits of virtual address space for user space, so let's
> make sure we stay within that limit with our preallocated memory block.
> 
> This fixes the MIPS user space targets when executed without command line
> option.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  linux-user/main.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/linux-user/main.c b/linux-user/main.c
> index c4d10ac..a2bc09d 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -57,7 +57,12 @@ int have_guest_base;
>   * This way we will never overlap with our own libraries or binaries or stack
>   * or anything else that QEMU maps.
>   */
> +# ifdef TARGET_MIPS
> +/* MIPS only supports 31 bits of virtual address space for user space */
> +unsigned long reserved_va = 0x77000000;
> +# else
>  unsigned long reserved_va = 0xf7000000;
> +# endif
>  #else
>  unsigned long reserved_va;
>  #endif

Thanks, applied.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

      parent reply	other threads:[~2013-01-08 15:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03 13:17 [Qemu-devel] [PATCH] linux-user: fix mips 32-on-64 prealloc case Alexander Graf
2013-01-03 17:19 ` Peter Maydell
2013-01-03 17:24   ` Alexander Graf
2013-01-03 18:39     ` Eric Johnson
2013-01-03 18:50       ` Richard Henderson
2013-01-03 19:09         ` Eric Johnson
2013-01-08 15:45 ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130108154516.GA25390@ohm.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=agraf@suse.de \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).