From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TsbNB-0008R6-UX
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 10:45:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TsbN6-0000R7-I2
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 10:45:53 -0500
Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:50230)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TsbN6-0000PT-B3
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 10:45:48 -0500
Date: Tue, 8 Jan 2013 16:45:16 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130108154516.GA25390@ohm.aurel32.net>
References: <1357219038-841-1-git-send-email-agraf@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1357219038-841-1-git-send-email-agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix mips 32-on-64 prealloc case
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Riku Voipio <riku.voipio@linaro.org>, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel qemu-devel <qemu-devel@nongnu.org>

On Thu, Jan 03, 2013 at 02:17:18PM +0100, Alexander Graf wrote:
> MIPS only supports 31 bits of virtual address space for user space, so let's
> make sure we stay within that limit with our preallocated memory block.
> 
> This fixes the MIPS user space targets when executed without command line
> option.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  linux-user/main.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/linux-user/main.c b/linux-user/main.c
> index c4d10ac..a2bc09d 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -57,7 +57,12 @@ int have_guest_base;
>   * This way we will never overlap with our own libraries or binaries or stack
>   * or anything else that QEMU maps.
>   */
> +# ifdef TARGET_MIPS
> +/* MIPS only supports 31 bits of virtual address space for user space */
> +unsigned long reserved_va = 0x77000000;
> +# else
>  unsigned long reserved_va = 0xf7000000;
> +# endif
>  #else
>  unsigned long reserved_va;
>  #endif

Thanks, applied.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net