From: Aurelien Jarno <aurelien@aurel32.net>
To: Eric Johnson <ericj@mips.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-mips: Allow DSP access to be disabled once enabled.
Date: Tue, 8 Jan 2013 16:45:21 +0100 [thread overview]
Message-ID: <20130108154521.GA25446@ohm.aurel32.net> (raw)
In-Reply-To: <1357626404-26955-1-git-send-email-ericj@mips.com>
On Mon, Jan 07, 2013 at 10:26:44PM -0800, Eric Johnson wrote:
> Clear the DSP hflags at the start of compute_hflags. Otherwise access
> is not properly disabled once enabled.
>
> Signed-off-by: Eric Johnson <ericj@mips.com>
> ---
> target-mips/cpu.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-mips/cpu.h b/target-mips/cpu.h
> index 31602ac..5963d62 100644
> --- a/target-mips/cpu.h
> +++ b/target-mips/cpu.h
> @@ -751,7 +751,7 @@ static inline void compute_hflags(CPUMIPSState *env)
> {
> env->hflags &= ~(MIPS_HFLAG_COP1X | MIPS_HFLAG_64 | MIPS_HFLAG_CP0 |
> MIPS_HFLAG_F64 | MIPS_HFLAG_FPU | MIPS_HFLAG_KSU |
> - MIPS_HFLAG_UX);
> + MIPS_HFLAG_UX | MIPS_HFLAG_DSP | MIPS_HFLAG_DSPR2);
> if (!(env->CP0_Status & (1 << CP0St_EXL)) &&
> !(env->CP0_Status & (1 << CP0St_ERL)) &&
> !(env->hflags & MIPS_HFLAG_DM)) {
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2013-01-08 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 6:26 [Qemu-devel] [PATCH] target-mips: Allow DSP access to be disabled once enabled Eric Johnson
2013-01-08 15:45 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108154521.GA25446@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=ericj@mips.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).