From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49542)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TsbN3-0008Br-Sx
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 10:45:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TsbN2-0000Pp-Jx
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 10:45:45 -0500
Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:50232)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TsbN2-0000Pl-Dc
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 10:45:44 -0500
Date: Tue, 8 Jan 2013 16:45:21 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130108154521.GA25446@ohm.aurel32.net>
References: <1357626404-26955-1-git-send-email-ericj@mips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1357626404-26955-1-git-send-email-ericj@mips.com>
Subject: Re: [Qemu-devel] [PATCH] target-mips: Allow DSP access to be
 disabled once enabled.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Johnson <ericj@mips.com>
Cc: qemu-devel@nongnu.org

On Mon, Jan 07, 2013 at 10:26:44PM -0800, Eric Johnson wrote:
> Clear the DSP hflags at the start of compute_hflags.  Otherwise access
> is not properly disabled once enabled.
> 
> Signed-off-by: Eric Johnson <ericj@mips.com>
> ---
>  target-mips/cpu.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/target-mips/cpu.h b/target-mips/cpu.h
> index 31602ac..5963d62 100644
> --- a/target-mips/cpu.h
> +++ b/target-mips/cpu.h
> @@ -751,7 +751,7 @@ static inline void compute_hflags(CPUMIPSState *env)
>  {
>      env->hflags &= ~(MIPS_HFLAG_COP1X | MIPS_HFLAG_64 | MIPS_HFLAG_CP0 |
>                       MIPS_HFLAG_F64 | MIPS_HFLAG_FPU | MIPS_HFLAG_KSU |
> -                     MIPS_HFLAG_UX);
> +                     MIPS_HFLAG_UX | MIPS_HFLAG_DSP | MIPS_HFLAG_DSPR2);
>      if (!(env->CP0_Status & (1 << CP0St_EXL)) &&
>          !(env->CP0_Status & (1 << CP0St_ERL)) &&
>          !(env->hflags & MIPS_HFLAG_DM)) {
> 

Thanks, applied.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net