From: Alberto Garcia <agarcia@igalia.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation
Date: Tue, 8 Jan 2013 16:57:54 +0100 [thread overview]
Message-ID: <20130108155754.GA25155@igalia.com> (raw)
In-Reply-To: <50EC256C.5060607@suse.de>
On Tue, Jan 08, 2013 at 02:55:56PM +0100, Andreas Färber wrote:
> IPACK_DEVICE()
>
> You have them defined in the header, please use them consistently.
>
> Also, please avoid accessing internals like &s->bus.qbus
> (BUS(s->bus)) or &s->dev.qdev (DEVICE(s->dev)).
Ok, I'm using all the defined macros and replaced all instances of
DO_UPCAST() with their checked equivalents.
I also removed all accesses to internals.
And I defined ipack_bus_new_inplace() (in the spirit of
pci_bus_new_inplace()) and updated tpci200_initfn().
Tell me if there's anything else I should change, else I can post the
new patches.
> Another thing to check (could be a follow-up) is whether the initfn
> can be split into instance_init (e.g., pci_set_*?) and initfn.
What's exactly that for in this case?
Berto
next prev parent reply other threads:[~2013-01-08 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 1:10 [Qemu-devel] [PATCH v4 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation Alberto Garcia
2013-01-08 1:10 ` [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 " Alberto Garcia
2013-01-08 13:55 ` Andreas Färber
2013-01-08 15:57 ` Alberto Garcia [this message]
2013-01-08 16:22 ` Andreas Färber
2013-01-08 16:37 ` Alberto Garcia
2013-01-09 0:36 ` Andreas Färber
2013-01-09 1:20 ` Alberto Garcia
2013-01-08 1:10 ` [Qemu-devel] [PATCH v4 2/2] Add GE IP-Octal 232 " Alberto Garcia
2013-01-08 18:08 ` Andreas Färber
2013-01-09 0:56 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108155754.GA25155@igalia.com \
--to=agarcia@igalia.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).