From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52272)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agarcia@igalia.com>) id 1TsbYv-0007wH-CT
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 10:58:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agarcia@igalia.com>) id 1TsbYq-0003hL-OX
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 10:58:01 -0500
Received: from smtp4.mundo-r.com ([212.51.32.151]:12127)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agarcia@igalia.com>) id 1TsbYq-0003h7-I9
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 10:57:56 -0500
Date: Tue, 8 Jan 2013 16:57:54 +0100
From: Alberto Garcia <agarcia@igalia.com>
Message-ID: <20130108155754.GA25155@igalia.com>
References: <cover.1357607262.git.agarcia@igalia.com>
	<4773138dce3a8e61f90ebc20837ff4a283137eb3.1357607262.git.agarcia@igalia.com>
	<50EC256C.5060607@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <50EC256C.5060607@suse.de>
Subject: Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack
 emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Tue, Jan 08, 2013 at 02:55:56PM +0100, Andreas Färber wrote:

> IPACK_DEVICE()
> 
> You have them defined in the header, please use them consistently.
> 
> Also, please avoid accessing internals like &s->bus.qbus
> (BUS(s->bus)) or &s->dev.qdev (DEVICE(s->dev)).

Ok, I'm using all the defined macros and replaced all instances of
DO_UPCAST() with their checked equivalents.

I also removed all accesses to internals.

And I defined ipack_bus_new_inplace() (in the spirit of
pci_bus_new_inplace()) and updated tpci200_initfn().

Tell me if there's anything else I should change, else I can post the
new patches.

> Another thing to check (could be a follow-up) is whether the initfn
> can be split into instance_init (e.g., pci_set_*?) and initfn.

What's exactly that for in this case?

Berto