From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46966)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agarcia@igalia.com>) id 1TskLP-0006Ml-K7
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 20:20:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agarcia@igalia.com>) id 1TskLO-0006T3-GK
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 20:20:39 -0500
Received: from smtp4.mundo-r.com ([212.51.32.151]:61482)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agarcia@igalia.com>) id 1TskLO-0006Ra-9o
	for qemu-devel@nongnu.org; Tue, 08 Jan 2013 20:20:38 -0500
Date: Wed, 9 Jan 2013 02:20:20 +0100
From: Alberto Garcia <agarcia@igalia.com>
Message-ID: <20130109012020.GB4199@igalia.com>
References: <cover.1357607262.git.agarcia@igalia.com>
	<4773138dce3a8e61f90ebc20837ff4a283137eb3.1357607262.git.agarcia@igalia.com>
	<50EC256C.5060607@suse.de> <20130108155754.GA25155@igalia.com>
	<50ECBBA2.6020500@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <50ECBBA2.6020500@suse.de>
Subject: Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack
 emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Wed, Jan 09, 2013 at 01:36:50AM +0100, Andreas Färber wrote:

> > I also removed all accesses to internals.
> 
> qdev->parent_bus is not supposed to be accessed either, there is
> qdev_get_parent_bus() as accessor function.

Yeah, that one I had also changed :)

(I didn't find any accessor for qbus->parent, so that one I didn't
change).

> > And I defined ipack_bus_new_inplace() (in the spirit of
> > pci_bus_new_inplace()) and updated tpci200_initfn().
> 
> Note that Paolo has a series refactoring the in-place bus init
> (either for qdev reset or for QOM reference counting) that you may
> want to take into account then.

I guess you mean https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg00548.html

I anyway didn't really change anything, I just moved the
qbus_create_inplace() call to ipack.c, so the fields of IPackBus are
not directly accessed from tpci200.

> Having the IPackBus not be a pointer but part of the exposing device
> initialized in-place would be desirable long-term but, like some
> other issues raised, not a criteria for initial patch acceptance
> IMO.

IPackBus is not a pointer, it is part of TPCI200State and is being
initialized in-place ...

Berto