From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TssbS-0000I1-Qn for qemu-devel@nongnu.org; Wed, 09 Jan 2013 05:09:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TssbO-0008FP-SW for qemu-devel@nongnu.org; Wed, 09 Jan 2013 05:09:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TssbO-0008F7-KQ for qemu-devel@nongnu.org; Wed, 09 Jan 2013 05:09:42 -0500 Date: Wed, 9 Jan 2013 10:09:35 +0000 From: "Daniel P. Berrange" Message-ID: <20130109100935.GB20716@redhat.com> References: <1357631962-10484-1-git-send-email-kraxel@redhat.com> <87mwwj22wo.fsf@codemonkey.ws> <50EC38FF.7010801@redhat.com> <87obgzzm3q.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87obgzzm3q.fsf@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH] pc: rename machine types Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Gerd Hoffmann , qemu-devel@nongnu.org On Tue, Jan 08, 2013 at 10:16:25AM -0600, Anthony Liguori wrote: > Gerd Hoffmann writes: > > > On 01/08/13 14:57, Anthony Liguori wrote: > >> Gerd Hoffmann writes: > >> > >>> Starting with release 1.4 we have a fully functional q35 machine type, > >>> i.e. "qemu -M q35" JustWorks[tm]. Update machine type names to reflect > >>> that: > >>> > >>> * pc-1.4 becomes piix-1.4 > >> > >> PIIX is the southbridge. A more appropriate (and google-able) name > >> would be i440fx-1.4. > > > > Fine with me. > > > >>> * q35-next becomes q35-1.4 > >> > >> I can't help but bikeshed a little here. I dislike that we are going > >> from something that's reasonable understandable (pc) to something > >> completely obscure (piix and q35). > > > > 'pc' is pretty generic. I want discontinue it, except for aliasing 'pc' > > to the default machine type, for compatibility reasons. > > > > I don't care that much what the actual names are. Using piix + q35 is > > inconsistent, so it isn't that a good choice indeed. So what now? > > > > (1) We could go for the host bridge and use 'i440fx' + 'q35'. > > (2) We could go for the south bridge and use 'piix' + 'ich9'. Either of these sound fine to me, with a slight preference for the first option. > > (3) Something different? If we really want 'pc' in the name, then (4) pci440fx & pcq35 (5) pcpiix & pcich9 > The issue I have with 'i440fx' and 'q35' is that it's basically > gibberish to a non-QEMU developer. With my users and/or libvirt developers hat on, I don't agree really. What Gerd suggests clearly states the hardware type being used by the machine. I think 'pc' is pretty much meaningless as a machine name because it can mean pretty much anything you want to it. It is akin to just calling your network device 'nic' and your disk device 'disk', which QEMU doesn't do for obvious reasons. What if someone can along and implemented a bunch more machine types for x86 ? Any name based soly on 'pc' would be even more meaningless than it already is. IMHO including the actual hardware name in some form is the right way to distinguish this. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|