From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60460)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Tsvmq-0007YK-Mz
	for qemu-devel@nongnu.org; Wed, 09 Jan 2013 08:33:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Tsvmp-0002jK-JD
	for qemu-devel@nongnu.org; Wed, 09 Jan 2013 08:33:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50440)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Tsvmp-0002jE-9o
	for qemu-devel@nongnu.org; Wed, 09 Jan 2013 08:33:43 -0500
Date: Wed, 9 Jan 2013 11:33:46 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130109113346.2ab2050d@doriath.home>
In-Reply-To: <1357466820-12860-3-git-send-email-lilei@linux.vnet.ibm.com>
References: <1357466820-12860-1-git-send-email-lilei@linux.vnet.ibm.com>
	<1357466820-12860-3-git-send-email-lilei@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On Sun,  6 Jan 2013 18:06:59 +0800
Lei Li <lilei@linux.vnet.ibm.com> wrote:

> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
>  qga/commands-posix.c |   12 ++++++++++++
>  qga/qapi-schema.json |   17 +++++++++++++++++
>  2 files changed, 29 insertions(+), 0 deletions(-)
> 
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 26b0fa0..190199d 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -109,6 +109,18 @@ static HostTimeInfo *get_host_time(void)
>      return host_time;
>  }
>  
> +struct HostTimeInfo *qmp_guest_get_time(Error **errp)
> +{
> +    HostTimeInfo *host_time = get_host_time();

The command is called guest_get_time() and runs in the guest, but it returns
HostTimeInfo. Is this correct?

> +
> +    if (!host_time) {
> +        error_set(errp, QERR_QGA_COMMAND_FAILED, "Failed to get host time");
> +        return NULL;
> +    }
> +
> +    return host_time;
> +}
> +
>  typedef struct GuestFileHandle {
>      uint64_t id;
>      FILE *fh;
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 7793aff..4a8b93c 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -100,6 +100,23 @@
>               'utc-offset': 'int' } }
>  
>  ##
> +# @guest-get-time:
> +#
> +# Get the information about host time in UTC and the
> +# UTC offset.
> +#
> +# This command tries to get the host time which is
> +# presumably correct, since need to be able to resynchronize
> +# clock to host in guest.
> +#
> +# Returns: @HostTimeInfo on success.
> +#
> +# Since 1.4
> +##
> +{ 'command': 'guest-get-time',
> +  'returns': 'HostTimeInfo' }
> +
> +##
>  # @GuestAgentCommandInfo:
>  #
>  # Information about guest agent commands.