From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsv1K-0005YG-HO for qemu-devel@nongnu.org; Wed, 09 Jan 2013 07:44:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tsv1J-00074D-HT for qemu-devel@nongnu.org; Wed, 09 Jan 2013 07:44:38 -0500 Received: from mail-bk0-f41.google.com ([209.85.214.41]:42304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tsv1J-00073o-AT for qemu-devel@nongnu.org; Wed, 09 Jan 2013 07:44:37 -0500 Received: by mail-bk0-f41.google.com with SMTP id jg9so889370bkc.0 for ; Wed, 09 Jan 2013 04:44:36 -0800 (PST) Date: Wed, 9 Jan 2013 13:44:33 +0100 From: Stefan Hajnoczi Message-ID: <20130109124433.GA391@stefanha-thinkpad.redhat.com> References: <1357543689-11415-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1357543689-11415-9-git-send-email-xiawenc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1357543689-11415-9-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com On Mon, Jan 07, 2013 at 03:28:06PM +0800, Wenchao Xia wrote: > This patch switch to internal common API to take group external > snapshots from qmp_transaction interface. qmp layer simply does > a translation from user input. > > Signed-off-by: Wenchao Xia > --- > blockdev.c | 215 ++++++++++++++++++++++++------------------------------------ > 1 files changed, 87 insertions(+), 128 deletions(-) An internal API for snapshots is not necessary. qmp_transaction() is already usable both from the monitor and C code. The QAPI code generator creates structs that can be accessed directly from C. qmp_transaction(), BlockdevAction, and BlockdevActionList *is* the snapshot API. It just doesn't support internal snapshots yet, which is what you are trying to add. To add internal snapshot support, define a BlockdevInternalSnapshot type in qapi-schema.json and add internal snapshot support in qmp_transaction(). qmp_transaction() was designed with this in mind from the beginning and dispatches based on BlockdevAction->kind. The patch series will become much smaller while still adding internal snapshot support. Stefan