From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] QCOW2 deduplication design
Date: Wed, 9 Jan 2013 21:57:43 +0100 [thread overview]
Message-ID: <20130109205552.GB17532@irqsave.net> (raw)
In-Reply-To: <CAJSP0QVHY2XLyUw6-pGt8pf_S9XP0xe_e1LKKP-Yf3UvakxASQ@mail.gmail.com>
> > Two GTrees are used to give access to the hashes : one indexed by hash and
> > one other indexed by physical offset.
>
> What is the GTree indexed by physical offset used for?
I think I can get rid of the second GTree for ram based deduplication.
It need to:
-Start qcow2 with the deduplication operation turned off while loading hashes.
So no need to check for new confliction hashes.
Dedup will be resumed after complete loading.
-For cluster removal and overflow the hash can be read for free from the
deduplication table using the physical cluster index. Then the gtree can be
manipulated with the hash.
I'll try to implement this tomorow.
Best regards
Benoît
prev parent reply other threads:[~2013-01-09 20:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 15:24 [Qemu-devel] QCOW2 deduplication design Benoît Canet
2013-01-09 16:16 ` Stefan Hajnoczi
2013-01-09 16:32 ` Eric Blake
2013-01-10 6:59 ` Stefan Hajnoczi
2013-01-09 16:40 ` Benoît Canet
2013-01-10 8:16 ` Stefan Hajnoczi
2013-01-10 15:18 ` Benoît Canet
2013-01-10 15:28 ` Stefan Hajnoczi
2013-01-09 20:57 ` Benoît Canet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109205552.GB17532@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).