From: "Michael S. Tsirkin" <mst@redhat.com>
To: Bill Paul <wpaul@windriver.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
yan@daynix.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] e1000: make ICS write-only
Date: Thu, 10 Jan 2013 00:48:53 +0200 [thread overview]
Message-ID: <20130109224853.GA12385@redhat.com> (raw)
In-Reply-To: <201301091421.50692.wpaul@windriver.com>
On Wed, Jan 09, 2013 at 02:21:50PM -0800, Bill Paul wrote:
> Of all the gin joints in all the towns in all the world, Michael S. Tsirkin
> had to walk into mine at 14:07:53 on Wednesday 09 January 2013 and say:
>
> > On Wed, Jan 09, 2013 at 01:50:39PM -0600, Anthony Liguori wrote:
> > > I figured this would be the case but this is where a comment in the code
> > > or commit message would have helped a lot in avoiding future confusion.
> > >
> > > Regards,
> > >
> > > Anthony Liguori
> >
> > I just sent a documentation patch, please take a look.
> > Thanks!
>
> Well, strictly speaking, VxWorks doesn't rely on the ICS behavior anymore, but
> it prefers it. I ran into problems with VMware and Simics too, as they also
> don't emulate the ICS behavior, and getting that fixed was more of an uphill
> battle. So as a compromise I added a check to the driver to see if the ICS
> register has 'real hardware behavior' or 'emulated behavior' and made it use
> an alternate interrupt handling scheme in the emulated case. The alternate
> scheme is a little less efficient than the ICS scheme in some cases (mainly
> when the PRO/1000 device's interrupt is shared), but it still handles
> interrupts reliably.
>
> That's a minor nit though. I'm fine with the comments as is. I just didn't
> want you do think VxWorks was completely brain damaged. :)
I guess I'll change it to
"The VxWorks PRO/1000 driver uses this behaviour."
> Note that I don't think VMware emulates the 'flexible RX mode' descriptor
> mechanism for the PRO/100 either, because the non-NDAed PRO/100 manual doesn't
> bother to mention it exists. I think this is something that was fixed in QEMU
> but I haven't had a chance to test it in a while. There's a similar problem
> with simulated the AMD PCnet/PCI devices (they only support the 'configuration
> block' setup method -- for the older non-PCI LANCE chips that was the only way
> to configure them but PCI devices starting with the am97c970 can be configured
> just by setting up registers).
>
> Honestly I'm surprised I still have all my hair and that it's still the same
> color.
>
> -Bill
Yes virtio is much easier. All bugs there are our own.
> --
> =============================================================================
> -Bill Paul (510) 749-2329 | Member of Technical Staff,
> wpaul@windriver.com | Master of Unix-Fu - Wind River Systems
> =============================================================================
> "I put a dollar in a change machine. Nothing changed." - George Carlin
> =============================================================================
next prev parent reply other threads:[~2013-01-09 22:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 10:51 [Qemu-devel] [PATCH] e1000: make ICS write-only Michael S. Tsirkin
2013-01-09 14:14 ` Stefan Hajnoczi
2013-01-09 14:45 ` Anthony Liguori
2013-01-09 15:28 ` Jason Wang
2013-01-09 15:34 ` Michael S. Tsirkin
2013-01-09 15:36 ` Jason Wang
2013-01-09 15:48 ` Michael S. Tsirkin
2013-01-09 17:30 ` Bill Paul
2013-01-09 17:51 ` Michael S. Tsirkin
2013-01-09 19:50 ` Anthony Liguori
2013-01-09 22:07 ` Michael S. Tsirkin
2013-01-09 22:21 ` Bill Paul
2013-01-09 22:48 ` Michael S. Tsirkin [this message]
2013-01-09 21:44 ` Michael S. Tsirkin
2013-01-09 22:05 ` Bill Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109224853.GA12385@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wpaul@windriver.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).