From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtDTS-0001MN-B6 for qemu-devel@nongnu.org; Thu, 10 Jan 2013 03:26:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtDTP-00021f-DG for qemu-devel@nongnu.org; Thu, 10 Jan 2013 03:26:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtDTP-00021R-6F for qemu-devel@nongnu.org; Thu, 10 Jan 2013 03:26:51 -0500 Date: Thu, 10 Jan 2013 09:26:47 +0100 From: Stefan Hajnoczi Message-ID: <20130110082647.GA20559@stefanha-thinkpad.redhat.com> References: <20130109220122.GA12016@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130109220122.GA12016@redhat.com> Subject: Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Jason Wang , Paolo Bonzini , Anthony Liguori , Bill Paul , qemu-devel@nongnu.org On Thu, Jan 10, 2013 at 12:01:22AM +0200, Michael S. Tsirkin wrote: > Add code comment to clarify the reason we set ICS with ICR: > the reason was previously undocumented and git > log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) > confused rather than clarified the comments. > Digging in the mailing list archives gives the real reason > https://lists.gnu.org/archive/html/qemu-devel/2009-06/msg00401.html > > Add code comment with an explanation supplied by Bill Paul. > > Signed-off-by: Michael S. Tsirkin > --- > hw/e1000.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) Thanks, applied to the net tree: https://github.com/stefanha/qemu/commits/net Stefan