From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51896)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TtDYr-0003ZE-DM
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 03:32:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TtDYo-0003WN-O2
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 03:32:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23023)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TtDYo-0003WD-G7
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 03:32:26 -0500
Date: Thu, 10 Jan 2013 09:32:16 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130110083216.GB20659@stefanha-thinkpad.redhat.com>
References: <1356690724-37891-1-git-send-email-jasowang@redhat.com>
	<1356690724-37891-2-git-send-email-jasowang@redhat.com>
	<20130109095625.GC31050@stefanha-thinkpad.redhat.com>
	<50ED8BE4.4020704@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50ED8BE4.4020704@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/12] tap: multiqueue support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: krkumar2@in.ibm.com, aliguori@us.ibm.com, kvm@vger.kernel.org, mst@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>, rusty@rustcorp.com.au, qemu-devel@nongnu.org, mprivozn@redhat.com, jwhan@filewood.snu.ac.kr, shiyer@redhat.com

On Wed, Jan 09, 2013 at 11:25:24PM +0800, Jason Wang wrote:
> On 01/09/2013 05:56 PM, Stefan Hajnoczi wrote:
> > On Fri, Dec 28, 2012 at 06:31:53PM +0800, Jason Wang wrote:
> >> diff --git a/qapi-schema.json b/qapi-schema.json
> >> index 5dfa052..583eb7c 100644
> >> --- a/qapi-schema.json
> >> +++ b/qapi-schema.json
> >> @@ -2465,7 +2465,7 @@
> >>  { 'type': 'NetdevTapOptions',
> >>    'data': {
> >>      '*ifname':     'str',
> >> -    '*fd':         'str',
> >> +    '*fd':         ['String'],
> > This change is not backwards-compatible.  You need to add a '*fds':
> > ['String'] field instead.
> 
> I'm not quite understand this case, I think it still work when we we
> just specify one fd.

You are right, the QemuOpts visitor shows no incompatibility.

But there is also a QMP interface: netdev_add.  I think changing the
type to a string list breaks compatibility there.

Stefan