From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56981)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TtE3S-00056N-Ug
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 04:04:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TtE3R-0003WP-Ck
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 04:04:06 -0500
Received: from mail-wi0-f182.google.com ([209.85.212.182]:48844)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TtE3R-0003WF-3e
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 04:04:05 -0500
Received: by mail-wi0-f182.google.com with SMTP id hn14so149845wib.3
	for <qemu-devel@nongnu.org>; Thu, 10 Jan 2013 01:04:04 -0800 (PST)
Date: Thu, 10 Jan 2013 10:04:01 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130110090401.GA1906@stefanha-thinkpad.redhat.com>
References: <1355941771-3418-1-git-send-email-namei.unix@gmail.com>
	<1357805027-13453-1-git-send-email-namei.unix@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1357805027-13453-1-git-send-email-namei.unix@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] sheepdog: implement direct write
	semantics
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Yuan <namei.unix@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>

On Thu, Jan 10, 2013 at 04:03:47PM +0800, Liu Yuan wrote:
> From: Liu Yuan <tailai.ly@taobao.com>
> 
> Sheepdog supports both writeback/writethrough write but has not yet supported
> DIRECTIO semantics which bypass the cache completely even if Sheepdog daemon is
> set up with cache enabled.
> 
> Suppose cache is enabled on Sheepdog daemon size, the new cache control is
> 
> cache=writeback # enable the writeback semantics for write
> cache=writethrough # enable the emulated writethrough semantics for write
> cache=directsync # disable cache competely
> 
> Guest WCE toggling on the run time to toggle writeback/writethrough is also
> supported.
> 
> Cc: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@gmail.com>
> Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
> ---
>  v2: adopt to current emulated writethrough cache setting
> 
>  block/sheepdog.c |   70 +++++++++++++++++++++++++++++++-----------------------
>  1 file changed, 40 insertions(+), 30 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>