From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43934)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TtF8h-0007Wf-1G
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 05:13:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TtF8b-0006MZ-Vz
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 05:13:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:65152)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TtF8b-0006MI-OC
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 05:13:29 -0500
Date: Thu, 10 Jan 2013 12:17:14 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130110101713.GA13451@redhat.com>
References: <20130109220122.GA12016@redhat.com>
	<20130110082647.GA20559@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130110082647.GA20559@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Bill Paul <wpaul@windriver.com>, qemu-devel@nongnu.org

On Thu, Jan 10, 2013 at 09:26:47AM +0100, Stefan Hajnoczi wrote:
> On Thu, Jan 10, 2013 at 12:01:22AM +0200, Michael S. Tsirkin wrote:
> > Add code comment to clarify the reason we set ICS with ICR:
> > the reason was previously undocumented and git
> > log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968)
> > confused rather than clarified the comments.
> > Digging in the mailing list archives gives the real reason
> > https://lists.gnu.org/archive/html/qemu-devel/2009-06/msg00401.html
> > 
> > Add code comment with an explanation supplied by Bill Paul.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  hw/e1000.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> 
> Thanks, applied to the net tree:
> https://github.com/stefanha/qemu/commits/net
> 
> Stefan

Actually I'm going to send v2 with a minor tweak.