From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TtHuP-0000Mv-0v
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:11:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TtHuN-0004rC-SZ
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:11:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50193)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TtHuN-0004r7-Kg
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:10:59 -0500
Date: Thu, 10 Jan 2013 11:10:57 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130110111057.4508f8bb@doriath.home>
In-Reply-To: <1357806754-8552-2-git-send-email-xiawenc@linux.vnet.ibm.com>
References: <1357806754-8552-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1357806754-8552-2-git-send-email-xiawenc@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V4 1/4] HMP: add QDict to info callback
	handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, chenwj@iis.sinica.edu.tw, armbru@redhat.com

On Thu, 10 Jan 2013 16:32:31 +0800
Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:

> diff --git a/monitor.c b/monitor.c
> index 9cf419b..c7b3014 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -123,7 +123,7 @@ typedef struct mon_cmd_t {
>      const char *help;
>      void (*user_print)(Monitor *mon, const QObject *data);
>      union {
> -        void (*info)(Monitor *mon);
> +        void (*info)(Monitor *mon, const QDict *qdict);
>          void (*cmd)(Monitor *mon, const QDict *qdict);

Is it possible to eliminate 'info' and use 'cmd' instead?