Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

[Stefan Hajnoczi <stefanha@redhat.com>]

On Thu, Jan 10, 2013 at 12:17:14PM +0200, Michael S. Tsirkin wrote:
> On Thu, Jan 10, 2013 at 09:26:47AM +0100, Stefan Hajnoczi wrote:
> > On Thu, Jan 10, 2013 at 12:01:22AM +0200, Michael S. Tsirkin wrote:
> > > Add code comment to clarify the reason we set ICS with ICR:
> > > the reason was previously undocumented and git
> > > log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968)
> > > confused rather than clarified the comments.
> > > Digging in the mailing list archives gives the real reason
> > > https://lists.gnu.org/archive/html/qemu-devel/2009-06/msg00401.html
> > > 
> > > Add code comment with an explanation supplied by Bill Paul.
> > > 
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> > >  hw/e1000.c | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > 
> > Thanks, applied to the net tree:
> > https://github.com/stefanha/qemu/commits/net
> > 
> > Stefan
> 
> Actually I'm going to send v2 with a minor tweak.

No problem.  I will wait with the next net pull request until v2 has
been merged.

Stefan