From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtI0U-00033S-Mk for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:17:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtI0R-0006RM-CB for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:17:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtI0R-0006RD-3o for qemu-devel@nongnu.org; Thu, 10 Jan 2013 08:17:15 -0500 Date: Thu, 10 Jan 2013 12:20:29 +0000 From: "Daniel P. Berrange" Message-ID: <20130110122029.GN6021@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, =?utf-8?B?6ams56OK?= On Wed, Jan 09, 2013 at 09:37:54PM +0000, Blue Swirl wrote: > On Wed, Jan 9, 2013 at 7:31 AM, =E9=A9=AC=E7=A3=8A wrote: > > > > > >>> Hi, > >>> The final effect is as follows: > >>> > >>> > >>> [malei@xentest-4-1 Fri Dec 28 ~/honeypot/xen/xen-4.1.2]$ qemu-img-x= en cat > >>> -f /1/boot.ini ~/vm-check.img > >>> [boot loader] > >>> timeout=3D30 > >>> default=3Dmulti(0)disk(0)rdisk(0)partition(1)\WINDOWS > >>> [operating systems] > >>> multi(0)disk(0)rdisk(0)partition(1)\WINDOWS=3D"Microsoft Windows XP > >>> Professional" /noexecute=3Doptin /fastdetect > >>> > >>> [malei@xentest-4-1 Fri Dec 28 ~/honeypot/xen/xen-4.1.2]$ qemu-img-x= en ls > >>> -l -d /1/ ~/vm-check.img > >>> =E3=80=90name size(bytes) dir? date > >>> create-time=E3=80=91 > >>> AUTOEXEC.BAT 0 file 2010-12-22 17:30:37 > >>> boot.ini 211 file 2010-12-23 01= :24:41 > >>> bootfont.bin 322730 file 2004-11-23 20:00:00 > >>> > >>> > >>> > >>> As you see above, the patch add two sub-commands for qemu-img-xen=EF= =BC=9Acat and > >>> ls. > >>> > >>> For details in the patch, please check the attachment. > >>> > >>> > > > > Does anyone prefer this feature?! >=20 > Nice feature, but this approach would just clutter QEMU and give only > readonly FAT or NTFS support. I think a more generally useful approach > would be to use NBD or iSCSI to export the block device data from the > image file (qemu-nbd already exists) and then make a tool that uses > some combination of NBD/iSCSI client, all GRUB file systems and FUSE > or other user space methods to access the contents of the filesystem. > Probably also UML with a simple guest agent could provide read/write > access to any file system that Linux supports. The latter is what libguestfs already provides. It boots a Linux kernel and mini initrd containing a guest agent, to provide APIs to do arbitrary manipulation of guest OS images. The reason libguestfs used a linux guest was precisely to avoid having to re-implement drivers for every filesystem in existance like this patch is trying todo. I don't think QEMU wants to be in the business of maintaining filesystem drivers, so I'd reject this proposed patch. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|