From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47591)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TtHGB-0007pl-Tx
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 07:29:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TtHG7-0001s8-40
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 07:29:27 -0500
Received: from mail-we0-f172.google.com ([74.125.82.172]:37337)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TtHG6-0001rM-Ss
	for qemu-devel@nongnu.org; Thu, 10 Jan 2013 07:29:23 -0500
Received: by mail-we0-f172.google.com with SMTP id r3so231213wey.3
	for <qemu-devel@nongnu.org>; Thu, 10 Jan 2013 04:29:22 -0800 (PST)
Date: Thu, 10 Jan 2013 13:29:19 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130110122919.GC30946@stefanha-thinkpad.redhat.com>
References: <20130106192356.GB5019@onelab2.iet.unipi.it>
	<20130107134944.GE17997@stefanha-thinkpad.redhat.com>
	<CA+hQ2+iQhvGqtSHMBqLeZMhgJmk9WAHrOpteRHNEaE4uEkaSZQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+hQ2+iQhvGqtSHMBqLeZMhgJmk9WAHrOpteRHNEaE4uEkaSZQ@mail.gmail.com>
Subject: Re: [Qemu-devel] unbounded qemu NetQue's ?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luigi Rizzo <rizzo@iet.unipi.it>
Cc: qemu-devel@nongnu.org

On Mon, Jan 07, 2013 at 03:27:30PM +0100, Luigi Rizzo wrote:
> On Mon, Jan 7, 2013 at 2:49 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> 
> > On Sun, Jan 06, 2013 at 08:23:56PM +0100, Luigi Rizzo wrote:
>  > diff -urp qemu-1.3.0-orig/net/queue.c qemu-1.3.0/net/queue.c
> > > --- qemu-1.3.0-orig/net/queue.c       2012-12-03 20:37:05.000000000+0100
> > > +++ qemu-1.3.0/net/queue.c    2013-01-06 19:38:12.000000000 +0100
> > > @@ -92,6 +92,9 @@ static void qemu_net_queue_append(NetQue
> >
> > Please also do it for qemu_net_queue_append_iov().
> >
> >
> the qemu code has many duplicate functions of the form foo() and foo_iov() .
> Not only here, but even in the backents (e.g. see net/tap.c)
> I think it would be good to settle on a single version of the function
> and remove or convert the non-iov instances.

Yes.  Patches welcome.

Stefan