From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtHTc-0005ft-4o for qemu-devel@nongnu.org; Thu, 10 Jan 2013 07:43:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtHTa-0005az-Vn for qemu-devel@nongnu.org; Thu, 10 Jan 2013 07:43:20 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:47691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtHTa-0005aq-Pv for qemu-devel@nongnu.org; Thu, 10 Jan 2013 07:43:18 -0500 Received: by mail-wi0-f180.google.com with SMTP id hj13so277591wib.1 for ; Thu, 10 Jan 2013 04:43:17 -0800 (PST) Date: Thu, 10 Jan 2013 13:43:15 +0100 From: Stefan Hajnoczi Message-ID: <20130110124315.GE30946@stefanha-thinkpad.redhat.com> References: <1357591119-40326-1-git-send-email-nickolai@csail.mit.edu> <20130108090336.GA31977@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Nickolai Zeldovich , qemu-devel@nongnu.org On Wed, Jan 09, 2013 at 08:43:51PM +0000, Blue Swirl wrote: > On Tue, Jan 8, 2013 at 9:03 AM, Stefan Hajnoczi wrote: > > On Mon, Jan 07, 2013 at 03:38:39PM -0500, Nickolai Zeldovich wrote: > >> memcpy() for overlapping regions is undefined behavior; use memmove() > >> instead in readline_hist_add(). > >> > >> Signed-off-by: Nickolai Zeldovich > >> --- > >> readline.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > > > I made a slight modification: keep the tab characters since the > > surrounding code still uses them. > > I think tabs should be fixed whenever possible, otherwise we may never > get them converted. Not in a one-line patch when the surrounding lines still use them. It creates a mess. Stefan