From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtJau-00079l-2M for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:59:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtJak-0000CH-9r for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:58:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtJak-0000C3-1y for qemu-devel@nongnu.org; Thu, 10 Jan 2013 09:58:50 -0500 Date: Thu, 10 Jan 2013 17:02:39 +0200 From: "Michael S. Tsirkin" Message-ID: <20130110150239.GC30731@redhat.com> References: <1357829141-25455-1-git-send-email-akong@redhat.com> <1357829141-25455-2-git-send-email-akong@redhat.com> <50EED588.9080706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50EED588.9080706@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH 1/2] move virtnet_send_command() above virtnet_set_mac_address() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: rusty@rustcorp.com.au, akong@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org On Thu, Jan 10, 2013 at 10:51:52PM +0800, Jason Wang wrote: > On 01/10/2013 10:45 PM, akong@redhat.com wrote: > > From: Amos Kong > > > > We will send vq command to set mac address in virtnet_set_mac_address() > > a little fix of coding style > > Maybe what you need is just a forward declaration. Nah functions should be ordered sensibly. > > > > Signed-off-by: Amos Kong