From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] virtio-scsi: abort in-flight I/O when the device is reset
Date: Thu, 10 Jan 2013 17:14:47 +0200 [thread overview]
Message-ID: <20130110151447.GE30731@redhat.com> (raw)
In-Reply-To: <1357829348-3496-1-git-send-email-pbonzini@redhat.com>
On Thu, Jan 10, 2013 at 03:49:06PM +0100, Paolo Bonzini wrote:
> This fixes the virtio-scsi problem by forcing a reset of the SCSI
> bus from virtio_reset. The reset will happen twice on machine
> initialization (and this is why I preferred the other approach,
> using qdev_reset_all in virtio code), but that's harmless.
Now I finally see what you worry about. It's the double reset.
Yes a bit ugly but harmless.
> Paolo Bonzini (2):
> qdev: add qbus_reset_all
> virtio-scsi: abort in-flight I/O when the device is reset
>
> hw/qdev-core.h | 12 ++++++++++++
> hw/qdev.c | 7 ++++++-
> hw/virtio-scsi.c | 4 ++++
> 3 files changed, 22 insertions(+), 1 deletion(-)
>
> --
> 1.8.1
next prev parent reply other threads:[~2013-01-10 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 14:49 [Qemu-devel] [PATCH 0/2] virtio-scsi: abort in-flight I/O when the device is reset Paolo Bonzini
2013-01-10 14:49 ` [Qemu-devel] [PATCH 1/2] qdev: add qbus_reset_all Paolo Bonzini
2013-01-10 18:34 ` Andreas Färber
2013-01-11 17:34 ` Andreas Färber
2013-01-10 14:49 ` [Qemu-devel] [PATCH 2/2] virtio-scsi: abort in-flight I/O when the device is reset Paolo Bonzini
2013-01-10 15:14 ` Michael S. Tsirkin [this message]
2013-01-11 16:46 ` [Qemu-devel] [PATCH 0/2] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110151447.GE30731@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).