From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtJmW-0002iS-8B for qemu-devel@nongnu.org; Thu, 10 Jan 2013 10:11:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtJmT-0003fv-J4 for qemu-devel@nongnu.org; Thu, 10 Jan 2013 10:11:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtJmT-0003fo-Bn for qemu-devel@nongnu.org; Thu, 10 Jan 2013 10:10:57 -0500 Date: Thu, 10 Jan 2013 17:14:47 +0200 From: "Michael S. Tsirkin" Message-ID: <20130110151447.GE30731@redhat.com> References: <1357829348-3496-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1357829348-3496-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] virtio-scsi: abort in-flight I/O when the device is reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Thu, Jan 10, 2013 at 03:49:06PM +0100, Paolo Bonzini wrote: > This fixes the virtio-scsi problem by forcing a reset of the SCSI > bus from virtio_reset. The reset will happen twice on machine > initialization (and this is why I preferred the other approach, > using qdev_reset_all in virtio code), but that's harmless. Now I finally see what you worry about. It's the double reset. Yes a bit ugly but harmless. > Paolo Bonzini (2): > qdev: add qbus_reset_all > virtio-scsi: abort in-flight I/O when the device is reset > > hw/qdev-core.h | 12 ++++++++++++ > hw/qdev.c | 7 ++++++- > hw/virtio-scsi.c | 4 ++++ > 3 files changed, 22 insertions(+), 1 deletion(-) > > -- > 1.8.1