From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] monitor: assert monitor_puts()'s loop invariant
Date: Thu, 10 Jan 2013 15:20:21 -0200 [thread overview]
Message-ID: <20130110152021.2b7fe9ce@doriath.home> (raw)
In-Reply-To: <1357823422-30850-1-git-send-email-armbru@redhat.com>
On Thu, 10 Jan 2013 14:10:22 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> Chiefly to hush up Coverity.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Applied to the qmp branch, thanks.
> ---
> monitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/monitor.c b/monitor.c
> index 9cf419b..c6eac60 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -270,6 +270,7 @@ static void monitor_puts(Monitor *mon, const char *str)
> char c;
>
> for(;;) {
> + assert(mon->outbuf_index < sizeof(mon->outbuf) - 1);
> c = *str++;
> if (c == '\0')
> break;
prev parent reply other threads:[~2013-01-10 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 13:10 [Qemu-devel] [PATCH] monitor: assert monitor_puts()'s loop invariant Markus Armbruster
2013-01-10 17:20 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110152021.2b7fe9ce@doriath.home \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).