From: "Michael S. Tsirkin" <mst@redhat.com>
To: akong@redhat.com
Cc: rusty@rustcorp.com.au, qemu-devel@nongnu.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [RFC PATCH 0/2] make mac programming for virtio net more robust
Date: Thu, 10 Jan 2013 17:28:29 +0200 [thread overview]
Message-ID: <20130110152829.GG30731@redhat.com> (raw)
In-Reply-To: <1357829141-25455-1-git-send-email-akong@redhat.com>
On Thu, Jan 10, 2013 at 10:45:39PM +0800, akong@redhat.com wrote:
> From: Amos Kong <akong@redhat.com>
>
> Currenly mac is programmed byte by byte. This means that we
> have an intermediate step where mac is wrong.
>
> Second patch introduced a new vq control command to set mac
> address in one time.
As you mention we could alternatively do it without
new commands, simply add a feature bit that says that MACs are
in the mac table.
This would be a much bigger patch, and I'm fine with either way.
Rusty what do you think?
> Amos Kong (2):
> move virtnet_send_command() above virtnet_set_mac_address()
> virtio-net: introduce a new control to set macaddr
>
> drivers/net/virtio_net.c | 105 ++++++++++++++++++++++------------------
> include/uapi/linux/virtio_net.h | 8 ++-
> 2 files changed, 66 insertions(+), 47 deletions(-)
>
> --
> 1.7.11.7
next prev parent reply other threads:[~2013-01-10 15:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 14:45 [Qemu-devel] [RFC PATCH 0/2] make mac programming for virtio net more robust akong
2013-01-10 14:45 ` [Qemu-devel] [RFC PATCH 1/2] move virtnet_send_command() above virtnet_set_mac_address() akong
2013-01-10 14:51 ` Jason Wang
2013-01-10 15:02 ` Michael S. Tsirkin
2013-01-10 14:45 ` [Qemu-devel] [RFC PATCH 2/2] virtio-net: introduce a new control to set macaddr akong
2013-01-10 14:57 ` Jason Wang
2013-01-16 5:23 ` Amos Kong
2013-01-16 9:17 ` Michael S. Tsirkin
2013-01-10 15:26 ` Michael S. Tsirkin
2013-01-11 0:43 ` Rusty Russell
2013-01-10 14:51 ` [Qemu-devel] [RFC PATCH] virtio-net: introduce a new macaddr control akong
2013-01-11 9:50 ` Stefan Hajnoczi
2013-01-10 15:08 ` [Qemu-devel] [RFC PATCH 0/2] make mac programming for virtio net more robust Amos Kong
2013-01-10 15:28 ` Michael S. Tsirkin [this message]
2013-01-11 2:23 ` Rusty Russell
2013-01-11 7:46 ` Michael S. Tsirkin
2013-01-11 14:52 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110152829.GG30731@redhat.com \
--to=mst@redhat.com \
--cc=akong@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).