From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtKgi-0003C6-7b for qemu-devel@nongnu.org; Thu, 10 Jan 2013 11:09:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtKgb-0002Fd-7i for qemu-devel@nongnu.org; Thu, 10 Jan 2013 11:09:04 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:40330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtKgb-0002FT-1Z for qemu-devel@nongnu.org; Thu, 10 Jan 2013 11:08:57 -0500 Received: by mail-wg0-f47.google.com with SMTP id dq11so351089wgb.14 for ; Thu, 10 Jan 2013 08:08:56 -0800 (PST) Date: Thu, 10 Jan 2013 17:02:03 +0100 From: Stefan Hajnoczi Message-ID: <20130110160203.GA12161@stefanha-thinkpad.redhat.com> References: <1355918961-3817-1-git-send-email-julien.grall@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1355918961-3817-1-git-send-email-julien.grall@citrix.com> Subject: Re: [Qemu-devel] [Bug 108996 V2] hw/dma.c: Fix converting of ioport_register* to MemoryRegion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Julien Grall Cc: kwolf@redhat.com, gson@gson.org, 1089996@bugs.launchpad.net, mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, hpoussin@reactos.org, stefanha@redhat.com, afaerber@suse.de On Wed, Dec 19, 2012 at 12:09:21PM +0000, Julien Grall wrote: > The commit 582299336879504353e60c7937fbc70fea93f3da introduced a 1-shift for > some offset in dma emulation. > > Before the previous commit, which converted ioport_register_* to MemoryRegion, > the DMA controller registered 8 ioports with the following formula: > base + ((8 + i) << d->shift) where 0 <= i < 8 > When an IO occured within a Memory Region, DMA callback receives an offset > relative to the started address. Here the started address is: > base + (8 << d->shift). > The offset should be: (i << d->shift). After the shift is reverted, the offset > are 0..7 not 1..8. > > Cc: 1089996@bugs.launchpad.net > Reviewed-by: Andreas Färber > Reported-by: Andreas Gustafsson > Signed-off-by: Julien Grall > --- > > Modification between V1 and V2: > * Modify the commit message to explain the problem. > > hw/dma.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) This patch resolves "dma: unknown iport 0" warnings for my Windows 8 guest. Tested-by: Stefan Hajnoczi