From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttf61-00005C-UN for qemu-devel@nongnu.org; Fri, 11 Jan 2013 08:56:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ttf5z-0007EM-3c for qemu-devel@nongnu.org; Fri, 11 Jan 2013 08:56:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttf5y-0007EG-Ry for qemu-devel@nongnu.org; Fri, 11 Jan 2013 08:56:31 -0500 Date: Fri, 11 Jan 2013 11:56:30 -0200 From: Luiz Capitulino Message-ID: <20130111115630.1f0bfdf1@doriath.home> In-Reply-To: <50EE5937.2040208@linux.vnet.ibm.com> References: <1357543689-11415-1-git-send-email-xiawenc@linux.vnet.ibm.com> <50EDF08E.7000402@redhat.com> <50EE5937.2040208@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, Pavel Hrdina , quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, pbonzini@redhat.com, dietmar@proxmox.com On Thu, 10 Jan 2013 14:01:27 +0800 Wenchao Xia wrote: > =E4=BA=8E 2013-1-10 6:34, Eric Blake =E5=86=99=E9=81=93: > > On 01/07/2013 12:27 AM, Wenchao Xia wrote: > >> These patch added a seperated layer to take internal or external sn= apshots > >> in a unified way, the granularity is block device, so other functions = can > >> just combine the request and submit, such as group snapshot, savevm. > >> > >> Total goal are: > >> Live back up vm in external or internal image, which need three fun= ctions: > >> 1 live snapshot block device internal/external. > >> 2 live save vmstate internal/external. > >> 3 combination of the function unit. > >> > >> This serial provide part one. > >> > > > > The design on this series needs to be coordinated with Pavel's > > attempts[1] to convert the existing HMP snapshot commands into QMP. I > > don't want to spend too much time reviewing two different divergent > > designs that both have the same goal of finally managing snapshots under > > QMP. > > > > [1] https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg01326.html > > > A bit difference: This serial are taking internal/external block > snapshots but Pavel's are focusing are vm whole internal snapshots. It Pavel's work makes savevm, loadvm and delvm available in QMP. Also note that we do have blockdev-snapshot-sync. How does this series relate to it? I don't know if it's just me but, honestly speaking, I'm getting confused about the various proposals and APIs for snapshots. IMHO, it's time to go back a bit from code and discuss the status of the current APIs, what's missing and what the proposals are. This should also include writing a wiki page, as Anthony has done for previous ideas (which worked quite well).