From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37207)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TtgVY-0003Zc-KF
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:27:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TtgVR-0007l2-Gi
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:27:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45886)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TtgVR-0007kw-8f
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:26:53 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0BFQqHE006080
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 11 Jan 2013 10:26:52 -0500
Date: Fri, 11 Jan 2013 15:40:46 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130111144046.GB2310@stefanha-thinkpad.muc.redhat.com>
References: <1357907697-16790-1-git-send-email-stefanha@redhat.com>
	<1357907697-16790-4-git-send-email-stefanha@redhat.com>
	<50F01371.2070709@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50F01371.2070709@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned
	virtio-blk requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

On Fri, Jan 11, 2013 at 02:28:17PM +0100, Paolo Bonzini wrote:
> Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto:
> > +        iov = &bounce_iov;
> > +        iov_cnt = 1;
> > +
> > +        if (read) {
> > +            /* Need to copy back from bounce buffer on completion */
> > +            read_qiov = g_slice_new(QEMUIOVector);
> > +            qemu_iovec_init(read_qiov, iov_cnt);
> > +            qemu_iovec_concat_iov(read_qiov, iov, iov_cnt, 0, qiov.size);
> 
> This is still wrong, how did you test it?

I sent it before reading the reviews from you and Kevin.  Bizarrely
Windows saw the files I copied to the disk - even across reboot (no
buffer cache involved?).  Or is Windows 8 doing tricks like "shutdown"
is actually "suspend to disk"?

Stefan