From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttifx-0008HZ-4K for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:45:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ttifu-0004PG-18 for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:45:52 -0500 Received: from mail-ia0-f174.google.com ([209.85.210.174]:54621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttift-0004P2-TZ for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:45:49 -0500 Received: by mail-ia0-f174.google.com with SMTP id o25so701533iad.33 for ; Fri, 11 Jan 2013 09:45:49 -0800 (PST) Sender: fluxion Date: Fri, 11 Jan 2013 11:39:10 -0600 From: mdroth Message-ID: <20130111173910.GH1543@vm> References: <1357899902-5316-1-git-send-email-armbru@redhat.com> <1357899902-5316-2-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1357899902-5316-2-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/6] qemu-ga: Document intentional fall through in channel_event_cb() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com On Fri, Jan 11, 2013 at 11:24:57AM +0100, Markus Armbruster wrote: > For clarity, and to hush up Coverity. > > Signed-off-by: Markus Armbruster Reviewed-by: Michael Roth > --- > qga/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qga/main.c b/qga/main.c > index a9b968c..47a6bea 100644 > --- a/qga/main.c > +++ b/qga/main.c > @@ -605,6 +605,7 @@ static gboolean channel_event_cb(GIOCondition condition, gpointer data) > if (!s->virtio) { > return false; > } > + /* fall through */ > case G_IO_STATUS_AGAIN: > /* virtio causes us to spin here when no process is attached to > * host-side chardev. sleep a bit to mitigate this > -- > 1.7.11.7 >