From: mdroth <mdroth@linux.vnet.ibm.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path
Date: Fri, 11 Jan 2013 11:42:58 -0600 [thread overview]
Message-ID: <20130111174258.GJ1543@vm> (raw)
In-Reply-To: <1357899902-5316-4-git-send-email-armbru@redhat.com>
On Fri, Jan 11, 2013 at 11:24:59AM +0100, Markus Armbruster wrote:
> Spotted by Coverity. Also document why we keep it open on success.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
> qga/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/qga/main.c b/qga/main.c
> index 1a22d8d..db47427 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -286,10 +286,12 @@ static bool ga_open_pidfile(const char *pidfile)
> goto fail;
> }
>
> + /* keep pidfile open & locked forever */
> return true;
>
> fail:
> unlink(pidfile);
> + close(pidfd);
> return false;
> }
> #else /* _WIN32 */
> --
> 1.7.11.7
>
next prev parent reply other threads:[~2013-01-11 17:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 10:24 [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups Markus Armbruster
2013-01-11 10:24 ` [Qemu-devel] [PATCH 1/6] qemu-ga: Document intentional fall through in channel_event_cb() Markus Armbruster
2013-01-11 17:39 ` mdroth
2013-01-11 10:24 ` [Qemu-devel] [PATCH 2/6] qemu-ga: Drop pointless lseek() from ga_open_pidfile() Markus Armbruster
2013-01-11 17:41 ` mdroth
2013-01-11 10:24 ` [Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path Markus Armbruster
2013-01-11 17:42 ` mdroth [this message]
2013-01-11 10:25 ` [Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_accept() " Markus Armbruster
2013-01-11 17:44 ` mdroth
2013-01-11 10:25 ` [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths Markus Armbruster
2013-01-11 17:44 ` mdroth
2013-01-11 10:25 ` [Qemu-devel] [PATCH 6/6] qemu-ga: Handle errors uniformely in ga_channel_open() Markus Armbruster
2013-01-11 17:47 ` mdroth
2013-01-14 22:25 ` Markus Armbruster
2013-01-11 16:07 ` [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups Eric Blake
2013-01-14 16:26 ` Luiz Capitulino
2013-01-14 19:45 ` mdroth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111174258.GJ1543@vm \
--to=mdroth@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).