From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39325)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TtifI-0005VZ-JL
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:45:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TtifF-0004Gr-RO
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:45:12 -0500
Received: from mail-ia0-f173.google.com ([209.85.210.173]:48722)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TtifF-0004GW-NV
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:45:09 -0500
Received: by mail-ia0-f173.google.com with SMTP id w21so1781099iac.32
	for <qemu-devel@nongnu.org>; Fri, 11 Jan 2013 09:45:09 -0800 (PST)
Sender: fluxion <flukshun@gmail.com>
Date: Fri, 11 Jan 2013 11:44:56 -0600
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20130111174456.GL1543@vm>
References: <1357899902-5316-1-git-send-email-armbru@redhat.com>
	<1357899902-5316-6-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1357899902-5316-6-git-send-email-armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on
 ga_channel_open() error paths
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

On Fri, Jan 11, 2013 at 11:25:01AM +0100, Markus Armbruster wrote:
> Spotted by Coverity.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>  qga/channel-posix.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/qga/channel-posix.c b/qga/channel-posix.c
> index 5579185..b530808 100644
> --- a/qga/channel-posix.c
> +++ b/qga/channel-posix.c
> @@ -153,6 +153,7 @@ static gboolean ga_channel_open(GAChannel *c, const gchar *path, GAChannelMethod
>          ret = ga_channel_client_add(c, fd);
>          if (ret) {
>              g_critical("error adding channel to main loop");
> +            close(fd);
>              return false;
>          }
>          break;
> -- 
> 1.7.11.7
>