From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tu99T-0005oG-5O for qemu-devel@nongnu.org; Sat, 12 Jan 2013 17:02:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tu99Q-00023v-Dh for qemu-devel@nongnu.org; Sat, 12 Jan 2013 17:02:07 -0500 Received: from mail-vb0-f47.google.com ([209.85.212.47]:65263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tu99Q-00023j-9j for qemu-devel@nongnu.org; Sat, 12 Jan 2013 17:02:04 -0500 Received: by mail-vb0-f47.google.com with SMTP id e21so2470706vbm.20 for ; Sat, 12 Jan 2013 14:02:02 -0800 (PST) Date: Sat, 12 Jan 2013 17:01:59 -0500 From: Kevin O'Connor Message-ID: <20130112220159.GA10403@morn.localdomain> References: <20121225103701.GA6688@t430s.redhat.com> <1356483340-12962-1-git-send-email-akong@redhat.com> <20130109040042.GC26614@morn.localdomain> <20130109050337.GB1760@t430s.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130109050337.GB1760@t430s.nay.redhat.com> Subject: Re: [Qemu-devel] [SeaBIOS PATCH v2] boot: support strict boot and make it configurable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: alex.williamson@redhat.com, seabios@seabios.org, dallan@redhat.com, qemu-devel@nongnu.org, gleb@redhat.com On Wed, Jan 09, 2013 at 01:03:37PM +0800, Amos Kong wrote: > On Tue, Jan 08, 2013 at 11:00:42PM -0500, Kevin O'Connor wrote: > > On Wed, Dec 26, 2012 at 08:55:40AM +0800, Amos Kong wrote: > > > Current seabios will try to boot from selected devices first, > > > if they are all failed, seabios will also try to boot from > > > un-selected devices. [...] > > I think it would be simpler to use the existing bootorder file instead > > of introducing a new "boot-strict" file. Something like the below > > (untested). > > Thanks for your patch. It's good. I thought you suggest me to add a > new type, and bootentry_add unselected devices to HALT type. > > I did a simple test, patch works. I will re-post this patch and change > qemu code to use this new type. Thanks. I committed my patch. -Kevin