Re: [Qemu-devel] [PATCH v12 0/8] pv event to notify host when the guest is panicked

[Hu Tao <hutao@cn.fujitsu.com>]

Hi Marcelo,

Sorry for the late reply.

On Tue, Dec 25, 2012 at 07:52:05PM -0200, Marcelo Tosatti wrote:
> On Thu, Dec 20, 2012 at 03:53:59PM +0800, Hu Tao wrote:
> > Hi,
> > 
> > Any comments?
> 
> As far as i can see, items 2 and 3 of
> 
> https://lkml.org/lkml/2012/11/12/588
> 
> Have not been addressed.
> 
> https://lkml.org/lkml/2012/11/20/653 contains discussions on those
> items.
> 
> 2) Format of the interface for other architectures (you can choose
> a different KVM supported architecture and write an example). It was
> your choice to choose an I/O port, which is x86 specific.

Unfortunately I don't have hardware other than x86 in hand to test it.

> 
> 3) Clear/documented management interface for the feature.

Patch #8 adds a document to describe the usage of pv event. But as you
are asking again, I must be misunderstanding the meaning of management
interface. Can you clarify it?

> 
> Note 3 is for management, not the guest<->host interface.
> 
> > On Wed, Dec 12, 2012 at 02:13:43PM +0800, Hu Tao wrote:
> > > This series implements a new interface, kvm pv event, to notify host when
> > > some events happen in guest. Right now there is one supported event: guest
> > > panic.
> > > 
> > > changes from v11:
> > > 
> > >   - add a new patch 'save/load cpu runstate'
> > >   - fix a bug of null-dereference when no -machine option is supplied
> > >   - reserve RUN_STATE_GUEST_PANICKED during migration
> > >   - add doc of enable_pv_event option
> > >   - disable reboot-on-panic if pv_event is on
> > > 
> > > v11: http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg04361.html
> > > 
> > > Hu Tao (7):
> > >   save/load cpu runstate
> > >   update kernel headers
> > >   add a new runstate: RUN_STATE_GUEST_PANICKED
> > >   add a new qevent: QEVENT_GUEST_PANICKED
> > >   introduce a new qom device to deal with panicked event
> > >   allower the user to disable pv event support
> > >   pv event: add document to describe the usage
> > > 
> > > Wen Congyang (1):
> > >   start vm after resetting it
> > > 
> > >  block.h                          |   2 +
> > >  docs/pv-event.txt                |  17 ++++
> > >  hw/kvm/Makefile.objs             |   2 +-
> > >  hw/kvm/pv_event.c                | 197 +++++++++++++++++++++++++++++++++++++++
> > >  hw/pc_piix.c                     |  11 +++
> > >  kvm-stub.c                       |   4 +
> > >  kvm.h                            |   2 +
> > >  linux-headers/asm-x86/kvm_para.h |   1 +
> > >  linux-headers/linux/kvm_para.h   |   6 ++
> > >  migration.c                      |   7 +-
> > >  monitor.c                        |   6 +-
> > >  monitor.h                        |   1 +
> > >  qapi-schema.json                 |   6 +-
> > >  qemu-config.c                    |   4 +
> > >  qemu-options.hx                  |   3 +-
> > >  qmp.c                            |   5 +-
> > >  savevm.c                         |   1 +
> > >  sysemu.h                         |   2 +
> > >  vl.c                             |  52 ++++++++++-
> > >  19 files changed, 312 insertions(+), 17 deletions(-)
> > >  create mode 100644 docs/pv-event.txt
> > >  create mode 100644 hw/kvm/pv_event.c
> > > 
> > > -- 
> > > 1.8.0.1.240.ge8a1f5a
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html