From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Ramesh G <rameshgx87@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Fix the glib deprecated APIs
Date: Mon, 14 Jan 2013 10:17:56 +0100 [thread overview]
Message-ID: <20130114091756.GD11260@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <50F04581.7080902@redhat.com>
On Fri, Jan 11, 2013 at 06:01:53PM +0100, Paolo Bonzini wrote:
> Il 11/01/2013 17:10, Ramesh G ha scritto:
> >
> > Hi,
> >
> > I got a couple of below compilation errors while compiling with glib >
> > 2.32.
> >
> > $ make
> > CC ../trace/simple.o
> > ../trace/simple.c: In function ‘trace_thread_create’:
> > ../trace/simple.c:407:5: error: ‘g_thread_create’ is deprecated
> > (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use
> > 'g_thread_new' instead [-Werror=deprecated-declarations]
> > ../trace/simple.c: In function ‘trace_backend_init’:
> > ../trace/simple.c:428:5: error: ‘g_cond_new’ is deprecated (declared at
> > /usr/include/glib-2.0/glib/deprecated/gthread.h:275)
> > [-Werror=deprecated-declarations]
> > ../trace/simple.c:429:5: error: ‘g_cond_new’ is deprecated (declared at
> > /usr/include/glib-2.0/glib/deprecated/gthread.h:275)
> > [-Werror=deprecated-declarations]
> > cc1: all warnings being treated as errors
> > make: *** [../trace/simple.o] Error 1
> > $
> >
> > I found these APIs have been deprecated in 2.32. Please find the patch
> > attached which fixes this problem. Please let me know your thoughts.
>
> Could you instead change it to use qemu-thread?
The reason to avoid QEMU APIs is to prevent entering an infinite loop if
a trace event is placed into the qemu-thread code.
Stefan
next prev parent reply other threads:[~2013-01-14 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 16:10 [Qemu-devel] Fix the glib deprecated APIs Ramesh G
2013-01-11 16:58 ` Peter Maydell
2013-01-11 17:01 ` Paolo Bonzini
2013-01-14 9:17 ` Stefan Hajnoczi [this message]
2013-01-14 9:21 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114091756.GD11260@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rameshgx87@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).