From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54805)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TugEk-00074L-Or
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 04:21:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TugEh-000417-VD
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 04:21:46 -0500
Received: from mail-wi0-f175.google.com ([209.85.212.175]:47721)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TugEh-00040t-Pe
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 04:21:43 -0500
Received: by mail-wi0-f175.google.com with SMTP id hm11so1093737wib.8
	for <qemu-devel@nongnu.org>; Mon, 14 Jan 2013 01:21:43 -0800 (PST)
Date: Mon, 14 Jan 2013 10:21:40 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130114092140.GE11260@stefanha-thinkpad.redhat.com>
References: <CAMEZSuvNX_G7kp=YZ9Gt_E2vxmiEzj6VB1iN1NxN3vRdfwMJQg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMEZSuvNX_G7kp=YZ9Gt_E2vxmiEzj6VB1iN1NxN3vRdfwMJQg@mail.gmail.com>
Subject: Re: [Qemu-devel] Fix the glib deprecated APIs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ramesh G <rameshgx87@gmail.com>
Cc: qemu-devel@nongnu.org

On Fri, Jan 11, 2013 at 09:40:59PM +0530, Ramesh G wrote:
> Hi,
> 
> I got a couple of below compilation errors while compiling with glib >
> 2.32.
> 
> $ make
>   CC    ../trace/simple.o
> ../trace/simple.c: In function ‘trace_thread_create’:
> ../trace/simple.c:407:5: error: ‘g_thread_create’ is deprecated (declared
> at /usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use 'g_thread_new'
> instead [-Werror=deprecated-declarations]
> ../trace/simple.c: In function ‘trace_backend_init’:
> ../trace/simple.c:428:5: error: ‘g_cond_new’ is deprecated (declared at
> /usr/include/glib-2.0/glib/deprecated/gthread.h:275)
> [-Werror=deprecated-declarations]
> ../trace/simple.c:429:5: error: ‘g_cond_new’ is deprecated (declared at
> /usr/include/glib-2.0/glib/deprecated/gthread.h:275)
> [-Werror=deprecated-declarations]
> cc1: all warnings being treated as errors
> make: *** [../trace/simple.o] Error 1
> $
> 
> I found these APIs have been deprecated in 2.32.  Please find the patch
> attached which fixes this problem.  Please let me know your thoughts.

Hi Ramakrishnan,
Please follow the guidelines at http://wiki.qemu.org/Contribute/SubmitAPatch, especially:
 * Please submit patches inline instead of as attachments so reviewiers
   can reply and quote your code easily.
 * Please follow QEMU coding style and run scripts/checkpatch.pl on your
   patch before submitting it.

Thanks,
Stefan