From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55673)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TugJS-0000Ji-HG
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 04:26:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TugJO-0005Co-Hh
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 04:26:38 -0500
Received: from mail-wi0-f178.google.com ([209.85.212.178]:58456)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TugJO-0005Ci-Bm
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 04:26:34 -0500
Received: by mail-wi0-f178.google.com with SMTP id hn3so1095998wib.17
	for <qemu-devel@nongnu.org>; Mon, 14 Jan 2013 01:26:33 -0800 (PST)
Date: Mon, 14 Jan 2013 10:26:30 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130114092630.GF11260@stefanha-thinkpad.redhat.com>
References: <1358012138-21613-1-git-send-email-pbonzini@redhat.com>
	<1358012138-21613-2-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1358012138-21613-2-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/27] qemu-option: move standard option
 definitions out of qemu-config.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Sat, Jan 12, 2013 at 06:35:12PM +0100, Paolo Bonzini wrote:
> @@ -2566,6 +2755,22 @@ int main(int argc, char **argv, char **envp)
>  
>      module_call_init(MODULE_INIT_QOM);
>  
> +    qemu_add_opts(&qemu_drive_opts);
> +    qemu_add_opts(&qemu_chardev_opts);
> +    qemu_add_opts(&qemu_device_opts);
> +    qemu_add_opts(&qemu_netdev_opts);
> +    qemu_add_opts(&qemu_net_opts);
> +    qemu_add_opts(&qemu_rtc_opts);
> +    qemu_add_opts(&qemu_global_opts);
> +    qemu_add_opts(&qemu_mon_opts);
> +    qemu_add_opts(&qemu_trace_opts);
> +    qemu_add_opts(&qemu_option_rom_opts);
> +    qemu_add_opts(&qemu_machine_opts);
> +    qemu_add_opts(&qemu_boot_opts);
> +    qemu_add_opts(&qemu_sandbox_opts);
> +    qemu_add_opts(&qemu_add_fd_opts);
> +    qemu_add_opts(&qemu_object_opts);
> +

Is there a reason to register in main() instead of using module init
functions?  IMO it's preferrable to keep options modular instead of
making them global and registering in main().

Stefan