qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com,
	Pavel Hrdina <phrdina@redhat.com>,
	quintela@redhat.com, qemu-devel@nongnu.org,
	Luiz Capitulino <lcapitulino@redhat.com>,
	pbonzini@redhat.com, dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way
Date: Mon, 14 Jan 2013 11:08:25 +0100	[thread overview]
Message-ID: <20130114100825.GI11260@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <50F368E9.5080201@linux.vnet.ibm.com>

On Mon, Jan 14, 2013 at 10:09:45AM +0800, Wenchao Xia wrote:
> 于 2013-1-11 21:56, Luiz Capitulino 写道:
> >On Thu, 10 Jan 2013 14:01:27 +0800
> >Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
> >
> >>于 2013-1-10 6:34, Eric Blake 写道:
> >>>On 01/07/2013 12:27 AM, Wenchao Xia wrote:
> >>>>    These patch added a seperated layer to take internal or external snapshots
> >>>>in a unified way, the granularity is block device, so other functions can
> >>>>just combine the request and submit, such as group snapshot, savevm.
> >>>>
> >>>>Total goal are:
> >>>>    Live back up vm in external or internal image, which need three functions:
> >>>>1 live snapshot block device internal/external.
> >>>>2 live save vmstate internal/external.
> >>>>3 combination of the function unit.
> >>>>
> >>>>    This serial provide part one.
> >>>>
> >>>
> >>>The design on this series needs to be coordinated with Pavel's
> >>>attempts[1] to convert the existing HMP snapshot commands into QMP.  I
> >>>don't want to spend too much time reviewing two different divergent
> >>>designs that both have the same goal of finally managing snapshots under
> >>>QMP.
> >>>
> >>>[1] https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg01326.html
> >>>
> >>    A bit difference: This serial are taking internal/external block
> >>snapshots but Pavel's are focusing are vm whole internal snapshots. It
> >
> >Pavel's work makes savevm, loadvm and delvm available in QMP. Also note
> >that we do have blockdev-snapshot-sync. How does this series relate to it?
> >
> >I don't know if it's just me but, honestly speaking, I'm getting confused
> >about the various proposals and APIs for snapshots.
> >
> >IMHO, it's time to go back a bit from code and discuss the status of the
> >current APIs, what's missing and what the proposals are.
> >
> >This should also include writing a wiki page, as Anthony has done for
> >previous ideas (which worked quite well).
> >
>   I agree, can you help create an account on qemu wiki for me?

I have created an account for you.  Please see the private message.

Stefan

      reply	other threads:[~2013-01-14 10:08 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07  7:27 [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way Wenchao Xia
2013-01-07  7:27 ` [Qemu-devel] [PATCH V2 01/10] block: export function bdrv_find_snapshot() Wenchao Xia
2013-01-07  7:28 ` [Qemu-devel] [PATCH V2 02/10] block: add function deappend() Wenchao Xia
2013-01-07  7:28 ` [Qemu-devel] [PATCH V2 03/10] error: add function error_set_check() Wenchao Xia
2013-01-07  7:28 ` [Qemu-devel] [PATCH V2 04/10] oslib-win32: add lock for time functions Wenchao Xia
2013-01-07 17:12   ` Stefan Weil
2013-01-08  2:27     ` Wenchao Xia
2013-01-07  7:28 ` Wenchao Xia
2013-01-07  7:28 ` [Qemu-devel] [PATCH V2 05/10] snapshot: design of internal common API to take snapshots Wenchao Xia
2013-01-07  7:28 ` [Qemu-devel] [PATCH V2 06/10] snapshot: implemention " Wenchao Xia
2013-01-07  7:28 ` [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction Wenchao Xia
2013-01-09 12:44   ` Stefan Hajnoczi
2013-01-10  3:21     ` Wenchao Xia
2013-01-10 12:41       ` Stefan Hajnoczi
2013-01-11  6:22         ` Wenchao Xia
2013-01-11  9:12           ` Stefan Hajnoczi
2013-01-14  2:56             ` Wenchao Xia
2013-01-14 10:06               ` Stefan Hajnoczi
2013-01-15  7:03                 ` Wenchao Xia
2013-03-12  8:30                   ` Wenchao Xia
2013-03-12 15:43                     ` Stefan Hajnoczi
2013-03-13  1:36                       ` Wenchao Xia
2013-03-13  8:42                         ` Stefan Hajnoczi
2013-03-13 10:18                     ` Kevin Wolf
2013-03-14  5:08                       ` Wenchao Xia
2013-03-14  8:22                         ` Kevin Wolf
2013-03-18 10:00                           ` Wenchao Xia
2013-01-07  7:28 ` [Qemu-devel] [PATCH V2 08/10] snapshot: qmp add internal snapshot transaction interface Wenchao Xia
2013-01-07  7:28 ` [Qemu-devel] [PATCH V2 09/10] snapshot: qmp add blockdev-snapshot-internal-sync interface Wenchao Xia
2013-01-07  7:28 ` [Qemu-devel] [PATCH V2 10/10] snapshot: hmp add internal snapshot support for block device Wenchao Xia
2013-01-09 22:34 ` [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way Eric Blake
2013-01-10  6:01   ` Wenchao Xia
2013-01-11 13:56     ` Luiz Capitulino
2013-01-14  2:09       ` Wenchao Xia
2013-01-14 10:08         ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130114100825.GI11260@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=dietmar@proxmox.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=phrdina@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=xiawenc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).