From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tugy3-0003kf-BV for qemu-devel@nongnu.org; Mon, 14 Jan 2013 05:08:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tugxw-0008LK-Pt for qemu-devel@nongnu.org; Mon, 14 Jan 2013 05:08:35 -0500 Received: from mail-we0-f179.google.com ([74.125.82.179]:35303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tugxw-0008L2-JW for qemu-devel@nongnu.org; Mon, 14 Jan 2013 05:08:28 -0500 Received: by mail-we0-f179.google.com with SMTP id r6so1902544wey.38 for ; Mon, 14 Jan 2013 02:08:28 -0800 (PST) Date: Mon, 14 Jan 2013 11:08:25 +0100 From: Stefan Hajnoczi Message-ID: <20130114100825.GI11260@stefanha-thinkpad.redhat.com> References: <1357543689-11415-1-git-send-email-xiawenc@linux.vnet.ibm.com> <50EDF08E.7000402@redhat.com> <50EE5937.2040208@linux.vnet.ibm.com> <20130111115630.1f0bfdf1@doriath.home> <50F368E9.5080201@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50F368E9.5080201@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, Pavel Hrdina , quintela@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino , pbonzini@redhat.com, dietmar@proxmox.com On Mon, Jan 14, 2013 at 10:09:45AM +0800, Wenchao Xia wrote: > 于 2013-1-11 21:56, Luiz Capitulino 写道: > >On Thu, 10 Jan 2013 14:01:27 +0800 > >Wenchao Xia wrote: > > > >>于 2013-1-10 6:34, Eric Blake 写道: > >>>On 01/07/2013 12:27 AM, Wenchao Xia wrote: > >>>> These patch added a seperated layer to take internal or external snapshots > >>>>in a unified way, the granularity is block device, so other functions can > >>>>just combine the request and submit, such as group snapshot, savevm. > >>>> > >>>>Total goal are: > >>>> Live back up vm in external or internal image, which need three functions: > >>>>1 live snapshot block device internal/external. > >>>>2 live save vmstate internal/external. > >>>>3 combination of the function unit. > >>>> > >>>> This serial provide part one. > >>>> > >>> > >>>The design on this series needs to be coordinated with Pavel's > >>>attempts[1] to convert the existing HMP snapshot commands into QMP. I > >>>don't want to spend too much time reviewing two different divergent > >>>designs that both have the same goal of finally managing snapshots under > >>>QMP. > >>> > >>>[1] https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg01326.html > >>> > >> A bit difference: This serial are taking internal/external block > >>snapshots but Pavel's are focusing are vm whole internal snapshots. It > > > >Pavel's work makes savevm, loadvm and delvm available in QMP. Also note > >that we do have blockdev-snapshot-sync. How does this series relate to it? > > > >I don't know if it's just me but, honestly speaking, I'm getting confused > >about the various proposals and APIs for snapshots. > > > >IMHO, it's time to go back a bit from code and discuss the status of the > >current APIs, what's missing and what the proposals are. > > > >This should also include writing a wiki page, as Anthony has done for > >previous ideas (which worked quite well). > > > I agree, can you help create an account on qemu wiki for me? I have created an account for you. Please see the private message. Stefan