From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuiPu-00046J-Ll for qemu-devel@nongnu.org; Mon, 14 Jan 2013 06:41:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuiPq-0001hE-As for qemu-devel@nongnu.org; Mon, 14 Jan 2013 06:41:26 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:57249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuiPq-0001h9-4a for qemu-devel@nongnu.org; Mon, 14 Jan 2013 06:41:22 -0500 Received: by mail-wg0-f47.google.com with SMTP id dq11so1910679wgb.26 for ; Mon, 14 Jan 2013 03:41:21 -0800 (PST) Date: Mon, 14 Jan 2013 12:41:16 +0100 From: Stefan Hajnoczi Message-ID: <20130114114116.GC11988@stefanha-thinkpad.redhat.com> References: <1355319999-30627-1-git-send-email-pbonzini@redhat.com> <1355319999-30627-11-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355319999-30627-11-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 10/20] mirror: add buf-size argument to drive-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Wed, Dec 12, 2012 at 02:46:29PM +0100, Paolo Bonzini wrote: > diff --git a/qmp-commands.hx b/qmp-commands.hx > index d8faad0..97c52c9 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -939,7 +939,7 @@ EQMP > .name = "drive-mirror", > .args_type = "sync:s,device:B,target:s,speed:i?,mode:s?,format:s?," > "on-source-error:s?,on-target-error:s?," > - "granularity:i?", > + "buf-size:i?,granularity:i?", granularity was also added in this patch series, so this doesn't matter, but in general it's nicer to append optional arguments on the end. This way, command option ordering doesn't change arbitrarily - that could confuse users. Stefan