From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TunWC-0001kq-Kh for qemu-devel@nongnu.org; Mon, 14 Jan 2013 12:08:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TunW6-0005K2-QW for qemu-devel@nongnu.org; Mon, 14 Jan 2013 12:08:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TunW6-0005Jw-HS for qemu-devel@nongnu.org; Mon, 14 Jan 2013 12:08:10 -0500 Date: Mon, 14 Jan 2013 15:08:11 -0200 From: Luiz Capitulino Message-ID: <20130114150811.63fe1455@doriath.home> In-Reply-To: <1358147387-8221-2-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1358147387-8221-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1358147387-8221-2-git-send-email-xiawenc@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 01/11] qemu-img: remove unused parameter in collect_image_info() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com On Mon, 14 Jan 2013 15:09:37 +0800 Wenchao Xia wrote: > Parameter *fmt was not used, so remove it. > > Reviewed-by: Eric Blake > Signed-off-by: Wenchao Xia > --- > qemu-img.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 85d3740..9dab48f 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -1186,8 +1186,7 @@ static void dump_json_image_info(ImageInfo *info) > > static void collect_image_info(BlockDriverState *bs, > ImageInfo *info, > - const char *filename, > - const char *fmt) > + const char *filename) collect_image_info_list() doc reads: @fmt: topmost image format (may be NULL to autodetect) However, right now only fmt=NULL is supported, as collect_image_info() ignores fmt altogether. So, if this patch is correct we better update the comment. Otherwise, we should improve collect_image_info() to actually obey fmt != NULL. > { > uint64_t total_sectors; > char backing_filename[1024]; > @@ -1361,7 +1360,7 @@ static ImageInfoList *collect_image_info_list(const char *filename, > } > > info = g_new0(ImageInfo, 1); > - collect_image_info(bs, info, filename, fmt); > + collect_image_info(bs, info, filename); > collect_snapshots(bs, info); > > elem = g_new0(ImageInfoList, 1);