From: Luiz Capitulino <lcapitulino@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com,
qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH V3 02/11] block: add bdrv_get_filename() function
Date: Mon, 14 Jan 2013 15:08:29 -0200 [thread overview]
Message-ID: <20130114150829.01875c0c@doriath.home> (raw)
In-Reply-To: <1358147387-8221-3-git-send-email-xiawenc@linux.vnet.ibm.com>
On Mon, 14 Jan 2013 15:09:38 +0800
Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
> This function will simply return the uri or filename used
> to open the image.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
> block.c | 5 +++++
> include/block/block.h | 1 +
> 2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/block.c b/block.c
> index 4e28c55..5f95da5 100644
> --- a/block.c
> +++ b/block.c
> @@ -2967,6 +2967,11 @@ BlockStatsList *qmp_query_blockstats(Error **errp)
> return head;
> }
>
> +const char *bdrv_get_filename(BlockDriverState *bs)
> +{
bs can be const.
> + return bs->filename;
> +}
> +
> const char *bdrv_get_encrypted_filename(BlockDriverState *bs)
> {
> if (bs->backing_hd && bs->backing_hd->encrypted)
> diff --git a/include/block/block.h b/include/block/block.h
> index 0719339..a0fc2a6 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -310,6 +310,7 @@ int bdrv_write_compressed(BlockDriverState *bs, int64_t sector_num,
> const uint8_t *buf, int nb_sectors);
> int bdrv_get_info(BlockDriverState *bs, BlockDriverInfo *bdi);
>
> +const char *bdrv_get_filename(BlockDriverState *bs);
> const char *bdrv_get_encrypted_filename(BlockDriverState *bs);
> void bdrv_get_backing_filename(BlockDriverState *bs,
> char *filename, int filename_size);
next prev parent reply other threads:[~2013-01-14 17:08 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 7:09 [Qemu-devel] [PATCH V3 00/11] add qmp/hmp interfaces for snapshot info Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 01/11] qemu-img: remove unused parameter in collect_image_info() Wenchao Xia
2013-01-14 17:08 ` Luiz Capitulino
2013-01-15 7:27 ` Wenchao Xia
2013-01-15 7:58 ` Wenchao Xia
2013-01-15 11:11 ` Luiz Capitulino
2013-01-16 3:10 ` Wenchao Xia
2013-01-16 17:56 ` Luiz Capitulino
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 02/11] block: add bdrv_get_filename() function Wenchao Xia
2013-01-14 17:08 ` Luiz Capitulino [this message]
2013-01-15 7:30 ` Wenchao Xia
2013-01-15 8:40 ` [Qemu-devel] IS_USER(s) in target-arm Shijesta Victor
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 03/11] block: add snapshot and image info query function Wenchao Xia
2013-01-14 17:22 ` Luiz Capitulino
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 04/11] qemu-img: switch image retrieving function Wenchao Xia
2013-01-14 11:25 ` Pavel Hrdina
2013-01-14 18:21 ` Luiz Capitulino
2013-01-15 2:37 ` Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 05/11] block: rename bdrv_query_info to bdrv_query_block_info Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 06/11] qmp: add interface query-images Wenchao Xia
2013-01-14 18:32 ` Luiz Capitulino
2013-01-15 10:27 ` Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot() Wenchao Xia
2013-01-14 23:39 ` Eric Blake
2013-01-15 10:24 ` Wenchao Xia
2013-01-15 17:57 ` Eric Blake
2013-01-16 4:28 ` Wenchao Xia
2013-01-15 12:01 ` Markus Armbruster
2013-01-15 13:18 ` Pavel Hrdina
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 08/11] qmp: add interface query-snapshots Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 09/11] hmp: export function hmp_handle_error() Wenchao Xia
2013-01-14 18:38 ` Luiz Capitulino
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 10/11] hmp: retrieve info from qmp for snapshot info Wenchao Xia
2013-01-14 7:09 ` [Qemu-devel] [PATCH V3 11/11] hmp: show snapshot on single block device Wenchao Xia
2013-01-14 11:15 ` Pavel Hrdina
2013-01-14 18:56 ` Luiz Capitulino
2013-01-15 2:36 ` Wenchao Xia
2013-01-15 11:05 ` Luiz Capitulino
2013-01-16 2:51 ` Wenchao Xia
2013-01-14 18:56 ` Luiz Capitulino
2013-01-14 18:58 ` [Qemu-devel] [PATCH V3 00/11] add qmp/hmp interfaces for snapshot info Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114150829.01875c0c@doriath.home \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).